fix #99 in createInLocation and add delete server by id#102
Merged
LKaemmerling merged 9 commits intoLKDevelopment:masterfrom Oct 14, 2024
Merged
fix #99 in createInLocation and add delete server by id#102LKaemmerling merged 9 commits intoLKDevelopment:masterfrom
LKaemmerling merged 9 commits intoLKDevelopment:masterfrom
Conversation
merge original
LKaemmerling
requested changes
Oct 14, 2024
Collaborator
LKaemmerling
left a comment
There was a problem hiding this comment.
Looks good, thank you! However please don't commit the composer.lock.
| @@ -0,0 +1,2719 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Hey, please don't commit the composer.lock
Contributor
Author
There was a problem hiding this comment.
Why shouldn`t we commit the composer.lock? This ensures, that every developer has the same dependency versions. Its also recommended from the composer docu. Composer Doku
Collaborator
There was a problem hiding this comment.
@BenjaminLeibinger yes, but not for libraries (as written in the composer doc as well). https://getcomposer.org/doc/02-libraries.md#lock-file
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.