SPF: add basic SPF Lua API #306
Conversation
|
btw, you can run |
Ahh, that presupposes running Docker which I usually try to avoid. Also generates a bunch of diff: diff --git a/docs/reference/kumod.openapi.json b/docs/reference/kumod.openapi.json
index db48fbbf..f6440451 100644
--- a/docs/reference/kumod.openapi.json
+++ b/docs/reference/kumod.openapi.json
@@ -6,7 +6,7 @@
"license": {
"name": "Apache-2.0"
},
- "version": "2024.10.15-3e4b6c13"
+ "version": "2024.10.15-46882b13"
},
"paths": {
"/api/admin/bounce/v1": {
@@ -443,8 +443,7 @@
"description": "The the preferred filename for the attachment",
"nullable": true
}
- },
- "additionalProperties": false
+ }
},
"BounceV1CancelRequest": {
"type": "object",
@@ -682,8 +681,7 @@
"example": "Sales",
"nullable": true
}
- },
- "additionalProperties": false
+ }
},
"Header": {
"oneOf": [
@@ -744,8 +742,7 @@
"trace_headers": {
"$ref": "#/components/schemas/HttpTraceHeaders"
}
- },
- "additionalProperties": false
+ }
},
"InjectV1Response": {
"type": "object",
@@ -909,8 +906,7 @@
"gender": "male"
}
}
- },
- "additionalProperties": false
+ }
},
"SetDiagnosticFilterRequest": {
"type": "object", |
|
I think you need to run |
3cf9624 to
f6f335b
Compare
819dcd5 to
1711fdb
Compare
|
@wez I think this is ready for a round of review (dare I say: done?), seems to be in a decent shape. |
d097739 to
d2456f3
Compare
wez
left a comment
There was a problem hiding this comment.
Just some minor nits really; this looks good, thank you!
|
(Mostly) addressed your feedback, let me know if there's anything else -- I'll start working on DMARC. |
|
Looks good, thank you! |
|
one minor tweak I'm just going to commit and push here is that you can simplify this bit and let mlua handle the type conversion for you: diff --git a/crates/mod-dns-resolver/src/lib.rs b/crates/mod-dns-resolver/src/lib.rs
index 823b6f30..2007205c 100644
--- a/crates/mod-dns-resolver/src/lib.rs
+++ b/crates/mod-dns-resolver/src/lib.rs
@@ -193,10 +193,10 @@ pub fn register(lua: &Lua) -> anyhow::Result<()> {
dns_mod.set(
"configure_test_resolver",
- lua.create_function(move |lua, zones: mlua::Value| {
+ lua.create_function(move |_lua, zones: Vec<String>| {
let mut resolver = TestResolver::default();
- for zone in lua.from_value::<Vec<String>>(zones)? {
- resolver = resolver.with_zone(&zone);
+ for zone in &zones {
+ resolver = resolver.with_zone(zone);
}
dns_resolver::reconfigure_resolver(resolver); |
Next step in #83. Currently untested.
r? @wez