[feat] add expo plugin config options#172
Merged
Merged
Conversation
Kudo
approved these changes
Mar 27, 2023
Kudo
left a comment
Owner
There was a problem hiding this comment.
sorry being late to take this. the change is awesome. thanks for having this great fix 👏
leotm
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Apr 18, 2023
patch-package react-native-v8 creates 271 diffs after no changes, so this excludes those diffs
Fix pod install:
[!] CocoaPods could not find compatible versions for pod "RNV8":
In Podfile:
RNV8 (from `../node_modules/react-native-v8`)
Specs satisfying the `RNV8 (from `../node_modules/react-native-v8`)` dependency were found, but they required a higher minimum deployment target.
Better solution would be a PR like:
Kudo/react-native-v8#172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to be able to configure if v8 is applied to iOS build. I would expect to be able to configure like this in my expo app.config.js.
Are you open to contributions?