Conversation
adding new APIs and examples
| <td>Font Awesome</td> | ||
| <td>IE11 support</td> | ||
| <td>Microsoft Edge (pre-chromium) support</td> | ||
| <td>LCP features</td> |
There was a problem hiding this comment.
probably, this is too much, because I cannot add a column for every new feature.
I created this table to show dependencies and browsers, not for specific features.
| { | ||
| img: `${PATH}/assets/images/carousel/milan-pegasus-gallery-statue.jpg`, | ||
| description: 'Description 1' | ||
| description: "Description 1", |
There was a problem hiding this comment.
it seems that you are using an IDE to replace quotes and add ",".
I'm always using a single quote ' to be consistent
| </table> | ||
| <br> | ||
|
|
||
| <h2 id="Source" class="link clickable"> |
There was a problem hiding this comment.
in my opinion, this interface should be moved inside features/modal-gallery because referenced only there.
Also, it's defined in ModalImage object, and not in a common one:
export interface ModalImage extends ImageData {
extUrl?: string;
downloadFileName?: string;
sources?: Source[];
}
What do you think? Am I missing something?
There was a problem hiding this comment.
I have nothing against it
| <td>No</td> | ||
| </tr> | ||
| <tr> | ||
| <td><b>11.1.0 (recommended)</b></td> |
There was a problem hiding this comment.
Also, I'm adding only the latest supported version for every major release.
I have to update previous rows with
- 8.0.1
- 9.1.0
- 10.0.1
because I missed this details in previous updates.
| <h2 class="link clickable"> | ||
| <a class="link-title" href="https://github.com/Ks89/angular-modal-gallery">Carousel lcp</a> | ||
| </h2> | ||
| <p>Carousel lcp demo.</p> |
There was a problem hiding this comment.
Example is ok, but I think It needs some more information. For example, what does it mean LCP? I Suggest to write at least a small phrase with a link to a website with some official information about the topic.
|
merged, but I'll apply some fixes on top of this PR |
Signed-off-by: Stefano Cappa <stefano.cappa.ks89@gmail.com>
@Ks89 as requested, I have updated docs and examples.
PS: The repo is broken because we need to update the main repo before