add getSunLowerTransit algorithm to detect solar midnight#234
Merged
KosherJava merged 2 commits intoKosherJava:masterfrom Apr 26, 2024
Merged
add getSunLowerTransit algorithm to detect solar midnight#234KosherJava merged 2 commits intoKosherJava:masterfrom
KosherJava merged 2 commits intoKosherJava:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
getSunLowerTransitmethod will find the sun transit time on the opposite side of the earth: longitudinal offset by 180 degrees.As part of this PR, the internal
getDateFromTimeconversion method has been enhanced to support additional solar events. To this end, the booleanisSunrisehas been changed to an enum.