clean up javadocs and code to look nicer#182
Closed
Elyahu41 wants to merge 0 commit intoKosherJava:masterfrom
Closed
clean up javadocs and code to look nicer#182Elyahu41 wants to merge 0 commit intoKosherJava:masterfrom
Elyahu41 wants to merge 0 commit intoKosherJava:masterfrom
Conversation
KosherJava
added a commit
that referenced
this pull request
Sep 4, 2022
Added Mincha Gedola, Mincha Ketana and Plag Hamincha as calculated by Rabbi Yaakov Moshe Hillel's Luach Ahavat Shalom. A special thanks to Rabbi Daniel Aaron Glauberman who computed the actual times used in the Luach and was able to clarify details about the calculations. Rabbi Glauberman's calculations used in the actual luach uses more accurate refraction values (ray traced based on actual average monthly weather measurements where available), solar radius (has a range that has a total of 3 to 4 second range based on the actual radius of the sun on a given day, and not a yearly average) and other accuracy tweaks that are not at this point included in this library (for example the high accuracy Jean Meeus algorithm that is about 3 seconds more accurate). Also includes some minor whitespace tweaks as suggested by @Elyahu41 in #182.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR looks huge but it changes nothing in the actual code of kosherjava. All I did in this PR is:
Please let me know if you want to keep some things.