Merged
Conversation
Owner
|
@yparitcher I know that it has been a long time. I had planned on refactoring things, but I see that will delay this too much, and I can easily do it after this is added. One small change request I have is the parsha names in the enums. Can you use the Ashkenazi transliteration as used throughout the codebase. Specifically see 5c14a07#diff-70152126b02d93ec0863fe69964ff69b |
KosherJava
reviewed
Aug 22, 2019
KosherJava
reviewed
Aug 22, 2019
KosherJava
reviewed
Aug 22, 2019
Contributor
Author
|
fixed |
KosherJava
approved these changes
Aug 23, 2019
Owner
KosherJava
left a comment
There was a problem hiding this comment.
Thank you @yparitcher for this PR that restores parsha functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a port of the parshah code from my C hebrew date & zmanim program libzmanim