adds Baal Hatanya zmanim#127
Conversation
| * there is at least one day where the sun does not rise, and one where it does not set, a null will be | ||
| * returned. See detailed explanation on top of the {@link AstronomicalCalendar} documentation. | ||
| */ | ||
| public Date getChatzosBaalHatanya() { |
There was a problem hiding this comment.
@yparitcher
This method is not needed. Since the sunrise and sunset offset are identical, chatzos will be at the exact same time as the regular chatzos method.
There was a problem hiding this comment.
i originaly thought the same, however when i tested it, the chatzos times are between 200 ms and one second apart depending on location, date, and which calculator is used. therefore i added it for complete acuracy, although you are right that most users will never tell the difference.
There was a problem hiding this comment.
@yparitcher the minor differences for getChatzosBaalHatanya is due to rounding and are really irrelevant. They will only confuse. Please also update the minor conflict (due to a recent change that I introduced - sorry).
Thanks
| * JavaScript / TypeScript - https://github.com/BehindTheMath/KosherZmanim | ||
| * Ruby - https://github.com/pinnymz/ruby-zmanim | ||
| * Scala - https://github.com/nafg/jewish-date | ||
| * C - https://github.com/yparitcher/libzmanim |
There was a problem hiding this comment.
@yparitcher very cool and thanks. I will hopefully merge this later.
|
fixed |
KosherJava
left a comment
There was a problem hiding this comment.
Thank you @yparitcher for this work that will be appreciated by many users. A special thanks for porting this to C as well.
Adjusts for edge cases where the location crosses the antimeridian to the east (and the theoretical cross to the west). Mirrors KosherJava/zmanim#127
Removed getChatzosBaalHatanya() Mirrors KosherJava/zmanim#127
adds methods to calculate zmanim per most chabad rabbonim based on the Baal Hatanya. the computed zmanim are like https://www.chabad.org/calendar/zmanim_cdo/aid/143790/jewish/Zmanim-Halachic-Times.htm
the sunrise and sunset methods were added as private methods, as they are not published in calendars and are only used to calculate the other zmanim