Merged
Conversation
rebase to kp/master
ca333
reviewed
Mar 31, 2021
iguana/m_notary_LTC_testnet
Outdated
| # Unlock wallet. | ||
| ./wp_testnet | ||
|
|
||
| curl --url "http://127.0.0.1:7776" --data "{\"conf\":\"litecoin.conf\",\"path\":\"${HOME#"/"}/.litecoin\",\"prefetchlag\":-1,\"poll\":1,\"active\":1,\"agent\":\"iguana\",\"method\":\"addcoin\",\"newcoin\":\"LTC\",\"startpend\":64,\"endpend\":64,\"services\":0,\"maxpeers\":512,\"RELAY\":-1,\"VALIDATE\":0,\"portp2p\":10111,\"minconfirms\":1,\"name\":\"litecoin\",\"netmagic\":\"deadbeef\",\"p2p\":9333,\"rpc\":9332,\"pubval\":48,\"p2shval\":5,\"wifval\":176}" |
Contributor
There was a problem hiding this comment.
maybe we change deadbeef to fbc0b6db just for clarity - https://github.com/litecoin-project/litecoin/blob/master/src/chainparams.cpp#L104-L107
Contributor
Author
There was a problem hiding this comment.
This is dead code from when iguana acted as a full node. I will change it for the sake of consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very simple change that will change all functionality from BTC to LTC. If we require both to function simultaneously, please let me know, but I expect this to be sufficient.
If there is some need to follow the
dpow/iguana/coinsconvention for activating LTC. I believe them_notary_LTC_testnetactivates it in a more sensible way, and I would like to see the new equivalent tom_notary_KMDfollow this same format.A small testnet has been running for the past week. I will roll out these changes to the larger 2021-testnet in about 6 hours from this post. You can see the result of it here:
https://live.blockcypher.com/ltc/address/LhGojDga6V1fGzQfNGcYFAfKnDvsWeuAsP/
Please squash when merged as there are commits pertaining to a temporary testnet that do not belong in the main repo.