Skip to content

purge#210

Merged
ca333 merged 4 commits intodevfrom
rm_hush
Oct 25, 2020
Merged

purge#210
ca333 merged 4 commits intodevfrom
rm_hush

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Oct 24, 2020

fixes #209

@todo
Copy link
Copy Markdown

todo bot commented Oct 24, 2020

use switch(coin->symbol)... - ca333

dPoW/iguana/iguana_wallet.c

Lines 1444 to 1449 in 8d99f0f

// TODO: use switch(coin->symbol)... - ca333
if ( strcmp(coin->symbol,"KMD") != 0 )
need_KMD = 1;
if ( strcmp(coin->symbol,"BTC") != 0 )
need_BTC = 1;
if ( strcmp(coin->symbol,"GAME") != 0 )

This comment was generated by todo based on a TODO comment in 8d99f0f in #210. cc @KomodoPlatform.

@tonymorony
Copy link
Copy Markdown
Contributor

tonymorony commented Oct 25, 2020

changes lgtm @ca333 but there is a super tiny merge conflict now in iguana/dpow/dpow_rpc.c because of GLEEC adding

@ca333
Copy link
Copy Markdown
Contributor Author

ca333 commented Oct 25, 2020

changes lgtm @ca333 but there is a super tiny merge conflict now in iguana/dpow/dpow_rpc.c because of GLEEC adding

thanks @tonymorony ! conflict resolved in f41641b

@ca333 ca333 merged commit 2913b30 into dev Oct 25, 2020
@smk762 smk762 deleted the rm_hush branch June 6, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcharang gcharang Awaiting requested review from gcharang

@DeckerSU DeckerSU Awaiting requested review from DeckerSU

@smk762 smk762 Awaiting requested review from smk762

@Alrighttt Alrighttt Awaiting requested review from Alrighttt

1 more reviewer

@tonymorony tonymorony tonymorony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ca333 @tonymorony