Proper notary scripts by kolobus · Pull Request #127 · KomodoPlatform/dPoW

kolobus · 2020-05-06T01:41:43Z

Replaces assetchains script, fiat-cli script from Komodo repo and old folders fiat and ac there. Also replaces m_notary_* manning scripts with single one.

Old scripts can be removed only after instructing NNs with new scripts and fixing docs.

Possible improvements:
~~1. Single ~/config.nn to define: pubkey, binary paths, delay, wallet passphrase file (?), seed ip.~~
2. jq to read json file instead of separate python scripts.

tonymorony · 2020-05-06T17:43:33Z

@kolobus https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/launch_assetchains.sh probably this one should be deleted in this PR?

TheComputerGenie · 2020-05-06T21:00:25Z

@kolobus https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/launch_assetchains.sh probably this one should be deleted in this PR?

please don't

tonymorony · 2020-05-06T21:11:33Z

@TheComputerGenie why? scripts moving to dPoW repo wasn't even announced yet and this script is outdated (and by the way not-working) duplicate now.

TheComputerGenie · 2020-05-06T21:21:08Z

Not sure which part is "outdated" or now broken, so I'll go back to my hole now

tonymorony · 2020-05-06T21:26:41Z

@TheComputerGenie probably you mixed dPOW and komodo (daemon) repositories or not checked script by link in my comment to which you've reffered, I'm not sure.

Not sure which part is "outdated"

https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/launch_assetchains.sh is outdated because https://github.com/kolobus/dPoW/blob/dev/iguana/assets.sh doing same thing

or now broken

https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/launch_assetchains.sh is not working because tilda inside ~ of "" so it's not parsing correct: https://github.com/KomodoPlatform/dPoW/blob/dev/iguana/launch_assetchains.sh#L8
In new script it fixed by usage of $HOME env var

kolobus · 2020-05-07T00:23:17Z

We should first implement and merge new scripts (m_notary replacement is also coming) and after that I'll cover deleting all old stuff and updating documents. Otherwise a lot of questions will be.

kolobus · 2020-05-07T00:24:00Z

Can we implement general config like above in this iteration, @tonymorony ?

tonymorony · 2020-05-07T00:48:03Z

We should first implement and merge new scripts (m_notary replacement is also coming) and after that I'll cover deleting all old stuff and updating documents. Otherwise a lot of questions will be.

I'm not about old stuff. I'm about script which was merged in this PR #124 ...

#127 (comment)

Can we implement general config like above in this iteration, @tonymorony ?

It looks like we reinventing this one:
https://github.com/webworker01/nntools/blob/master/config.example

DeckerSU · 2020-05-07T01:21:32Z

I guess we are paying too much attention to all of these scripts. My offer is to make something like "base version". Mean, assets.sh in this PR is enough for start and enough for newcomers (just need to describe its features in docs). All other improvements everybody can made by themselves. Personally me, never used these scripts, probably only assetchains.old was important, as just a storage of AC params 😀

p.s. we can improove these scripts infinitely, but as i guess main purpose of these scripts is to allow everyone "quick start" and learn how the things working. after op is understand how it's working - he definitely will write his own version with improvements needed by him.

just an example, i can offer following:

https://github.com/KomodoPlatform/dPoW/pull/127/files#r421191604 (#!/bin/bash assumes it is always installed to /bin/ which can cause issues, #!/usr/bin/env bash searches the user's PATH to find the bash binary)
https://github.com/KomodoPlatform/dPoW/pull/127/files#r421192500 (to allow people start script as delay=0 ./assets.sh)
but do we really need changes like this and few days on discussing that?

DeckerSU · 2020-05-07T01:47:50Z

iguana/assets.sh

@@ -0,0 +1,39 @@
+#!/bin/bash


Suggested change

#!/bin/bash

#!/usr/bin/env bash

DeckerSU · 2020-05-07T01:50:50Z

iguana/assets.sh

+seed_ip=`getent hosts zero.kolo.supernet.org | awk '{ print $1 }'`
+komodo_binary="$HOME/komodo/src/komodod"
+cli_binary="$HOME/komodo/src/komodo-cli"
+delay=20


Suggested change

delay=20

delay=${delay:-20}

Thanks for hint. It's moved to config in newer version

Deleting not working script duplicating one PRed in #127

kolobus · 2020-05-08T08:55:56Z

I added newer versions of both scripts with fixes. Tested on both nodes but needs more attention before merging.

Will also require huge manual modification for new season.

pipefail commented out because it should not fail when one chain/operation failed.

DeckerSU · 2020-05-08T13:16:21Z

iguana/m_notary_KMD

-# unlock any locked utxos. This will unlock utxos for both iguans, need a filter for address to only unlock the pubkey you need to restart. 
-komodo-cli lockunspent true `komodo-cli listlockunspent | jq -c .` 
+# unlock any locked utxos. This will unlock utxos for both iguans, need a filter for address to only unlock the pubkey you need to restart.
+komodo-cli lockunspent true `komodo-cli listlockunspent | jq -c .`


This should use komodo_binary variable as well.

No changes here. That’s an old script. My editor fixed white spaces there and commited it, sorry, my mistake

It's not about whitespaces ... it's about komodo-cli binary. Script uses system-wide komodo-cli binary, but should use komodo_binary variable.

It should be:

$komodo_binary lockunspent true `komodo-cli listlockunspent | jq -c .`

instead of:

komodo-cli lockunspent true `komodo-cli listlockunspent | jq -c .`

That’s an old script not related to this PR. I will remove that from commit ASAP

Please, keep this spaces fix in this PR. Editor insists on this fix :) Thanks.

DeckerSU · 2020-05-08T13:25:43Z

iguana/notary.sh

+    sleep 3
+
+    # TODO: Need to get some seeds for both networks.
+    curl --url "http://127.0.0.1:7776" --data "{\"agent\":\"iguana\",\"method\":\"addnotary\",\"ipaddr\":\"178.128.93.117\"}"   # lukechilds_AR


Also, good to change this bunch of curl calls on something like this:

declare -a seeds_mainnet=(178.128.93.117 67.207.94.69) for seed_ip in "${seeds_mainnet[@]}" do curl --url "http://127.0.0.1:7776" --data "{\"agent\":\"iguana\",\"method\":\"addnotary\",\"ipaddr\":\"${seed_ip}\"}" done

DeckerSU

...

kolobus · 2020-05-08T13:40:08Z

Isn’t it different servers or at min different users? Both passphrases should never be in a same file

DeckerSU · 2020-05-08T13:52:59Z

Isn’t it different servers or at min different users? Both passphrases should never be in a same file

yes, you are absolutely right. that was my bad, that's why i deleted comment right after i posted it. all is ok in that part. sorry for false alarm.

assets.sh

d6e2e58

kolobus requested review from DeckerSU, ca333 and tonymorony May 6, 2020 01:41

DeckerSU reviewed May 7, 2020

View reviewed changes

iguana/assets.sh Outdated

@@ -0,0 +1,39 @@

#!/bin/bash

Copy link
Copy Markdown

Contributor

DeckerSU May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

#!/bin/bash

#!/usr/bin/env bash

DeckerSU reviewed May 7, 2020

View reviewed changes

tonymorony approved these changes May 7, 2020

View reviewed changes

tonymorony added a commit that referenced this pull request May 7, 2020

Delete launch_assetchains.sh

14ac631

Deleting not working script duplicating one PRed in #127

tonymorony mentioned this pull request May 7, 2020

Delete launch_assetchains.sh #128

Merged

DeckerSU approved these changes May 7, 2020

View reviewed changes

tonymorony marked this pull request as draft May 7, 2020 03:45

Proper notary scripts

6f3daf3

KomodoPlatform deleted a comment from todo bot May 8, 2020

kolobus requested review from DeckerSU and tonymorony May 8, 2020 08:56

kolobus changed the title ~~Proper assetchains script~~ Proper notary scripts May 8, 2020

DeckerSU reviewed May 8, 2020

View reviewed changes

DeckerSU suggested changes May 8, 2020

View reviewed changes

kolobus marked this pull request as ready for review May 10, 2020 01:12

ca333 merged commit 997df1f into KomodoPlatform:dev May 11, 2020

Conversation

kolobus commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonymorony commented May 6, 2020

Uh oh!

TheComputerGenie commented May 6, 2020

Uh oh!

tonymorony commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheComputerGenie commented May 6, 2020

Uh oh!

tonymorony commented May 6, 2020

Uh oh!

kolobus commented May 7, 2020

Uh oh!

kolobus commented May 7, 2020

Uh oh!

tonymorony commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeckerSU commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kolobus commented May 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeckerSU May 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeckerSU left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kolobus commented May 8, 2020

Uh oh!

DeckerSU commented May 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kolobus commented May 6, 2020 •

edited

Loading

tonymorony commented May 6, 2020 •

edited

Loading

tonymorony commented May 7, 2020 •

edited

Loading

DeckerSU commented May 7, 2020 •

edited

Loading

DeckerSU May 8, 2020 •

edited

Loading

DeckerSU left a comment •

edited

Loading

DeckerSU commented May 8, 2020 •

edited

Loading