Skip to content

0.1.5#117

Merged
ca333 merged 28 commits intomasterfrom
dev
May 18, 2020
Merged

0.1.5#117
ca333 merged 28 commits intomasterfrom
dev

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Apr 24, 2020

No description provided.

@ca333
Copy link
Copy Markdown
Contributor Author

ca333 commented Apr 24, 2020

@kolobus fyi, assetchains scripts moved to dPoW, thus future dpow coin integrations do not require komodo repo updates anymore.

TODO:

  • Plz create launch_assetchains.sh script to start all chains from assetchains.json and remove obsoleted and redundant scripts and jsons (PR).
  • bump version in iguana/version
  • gather details ref. BLUR and add to update instruction draft, this is a 3P codebase (cryptonote)

@kolobus kolobus self-requested a review April 25, 2020 18:58
@ca333 ca333 mentioned this pull request May 4, 2020
@kolobus
Copy link
Copy Markdown
Contributor

kolobus commented May 5, 2020

Please, delay merging this. I have seen newer much better asset chains script.

kolobus and others added 10 commits May 6, 2020 04:34
Deleting not working script duplicating one PRed in #127
Since LIBC 2.28 fmul exists in math.h, without this commit
we will have following errors during build with _GNU_SOURCE
define:

In file included from OS_portable.h:80,
                 from OS_nonportable.c:34:
../includes/curve25519.h:43:9: error: conflicting types for 'fmul'
 bits320 fmul(const bits320 in2,const bits320 in);
         ^~~~
- myinfo->notarymutex and myinfo->dpowmutex seems sometimes
initialised not correctly. as a result we had following
debug messages:

[ Decker ] ./dpow/dpow_network.c.1480 (dpow_addnotary): ip = 149.56.30.227
[ Decker ] ./dpow/dpow_network.c.1481 (dpow_addnotary): err_unlock = 22
[ Decker ] ./dpow/dpow_network.c.1418 (dpow_addnotary): ip = x.x.x.x
[ Decker ] ./dpow/dpow_network.c.1419 (dpow_addnotary): err_lock = 22
[ Decker ] ./dpow/dpow_network.c.1480 (dpow_addnotary): ip = x.x.x.x
[ Decker ] ./dpow/dpow_network.c.1481 (dpow_addnotary): err_unlock = 22
[ Decker ] ./dpow/dpow_network.c.1418 (dpow_addnotary): ip = 149.56.30.227

where 22 means [EINVAL]
The value specified by mutex does not refer to an initialized mutex object.

And finally it leads to app crash:

iguana: ../nptl/pthread_mutex_lock.c:433: __pthread_mutex_lock_full: Assertion `INTERNAL_SYSCALL_ERRNO (e, __err) != ESRCH || !robust' failed.

So, we changed these mutexes to:

myinfo->dpowmutex -> def_dpowmutex
myinfo->notarymutex -> def_notarymutex

with initialisation with PTHREAD_MUTEX_INITIALIZER .
@ca333
Copy link
Copy Markdown
Contributor Author

ca333 commented May 18, 2020

Can we write down / link to what are the reasons for this change?
Does it ensure funding of the devs or is there sometimes in particular which can not be achieved with 4 dev nodes?
Which two Regions will have one spot less open for election?

Adding this for sake of transparency and protocol as it was discussed/clarified internally on discord:

it is mainly because we are scaling up the team over the coming months and are developing dPoW2 - the growing QA and additional opSEC division are the main reasons for the additional 2 spots. We will likely increase the count to 66 (64 = a current datatype limitation) but this is not set in stone yet.

Will add further details/infos prior to S5.

@ca333 ca333 marked this pull request as ready for review May 18, 2020 16:26
@ca333 ca333 removed the request for review from kolobus May 18, 2020 16:26
Copy link
Copy Markdown
Contributor

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ca333 ca333 merged commit 6feaead into master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants