Skip to content

Added notarizations status badges#11

Merged
tonymorony merged 7 commits intoKomodoPlatform:devfrom
tonymorony:dev
Dec 23, 2019
Merged

Added notarizations status badges#11
tonymorony merged 7 commits intoKomodoPlatform:devfrom
tonymorony:dev

Conversation

@tonymorony
Copy link
Copy Markdown
Contributor

@tonymorony tonymorony requested a review from ca333 December 23, 2019 17:14
@tonymorony
Copy link
Copy Markdown
Contributor Author

tonymorony commented Dec 23, 2019

Looks like I have to set maxAge header as shields do for their badges:
https://img.shields.io/travis/rust-lang/rust.svg?maxAge=2592000
otherwise it's caching on GH side and not refreshing according to my changes. Will work on it

@tonymorony tonymorony removed the request for review from ca333 December 23, 2019 17:19
@tonymorony
Copy link
Copy Markdown
Contributor Author

looks fine now (btw problem was actual for CI badge as well)

@tonymorony tonymorony requested a review from ca333 December 23, 2019 17:28
Copy link
Copy Markdown
Contributor

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use https://github.com/badges/shields natively instead of https://github.com/tonymorony/dpow_badges.

dPoW could even get officially listed as a service (not urgent/priority):
https://github.com/badges/shields/blob/master/doc/TUTORIAL.md

@tonymorony tonymorony requested a review from ca333 December 23, 2019 18:01
Copy link
Copy Markdown
Contributor

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for temporary badge usage (functionality given) - we will work on native shields.io integration

@tonymorony tonymorony merged commit 3f7bf99 into KomodoPlatform:dev Dec 23, 2019
Alrighttt added a commit that referenced this pull request Mar 5, 2020
Update m_notary_testnet added dudezmobi.vrsc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants