[RFR] fix docker setup for dev env#580
Merged
nicolasmure merged 2 commits intomasterfrom Jun 11, 2019
Merged
Conversation
66265e2 to
66eac67
Compare
Contributor
Author
|
@NiR- I updated this PR for the php7.1 bump. However, the php 7.3 image fails to build as the ssh2 extension is not available for php 7.3 yet. |
66eac67 to
b0d1f99
Compare
akerouanton
reviewed
Jun 7, 2019
akerouanton
approved these changes
Jun 11, 2019
nicolasmure
added a commit
that referenced
this pull request
Jun 11, 2019
nicolasmure
added a commit
that referenced
this pull request
Jun 11, 2019
nicolasmure
added a commit
that referenced
this pull request
Jun 11, 2019
The tests are using env vars to run. These env vars are storing the credentials to the different backends. For the CI, these env vars are set on the project settings (on travis for instance). For the development of Gaufrette, and considering the merge of (#580), the tests should be ran using docker. The docker setup uses env vars defined in .env files, so we no longer need to define such vars in the phpunit.xml file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not able to build the images from the current docker setup :
so I rewrote the docker setup for dev env.
The main change with the previous setup is that the dependencies are not installed in the image any more, but directly on the host machine as the whole project is mounted on
/appin the container (see thedocker-compose.ymlfile). Doing so, it's easier to look at the source code of vendors with your text editor.The drawback is that it's not as easy as before to switch from a php version to another (and so to launch the tests on various php versions). There's an instruction in the
READMEwhich explains how to switch between php versions. But afterall, I'm not sure that it's gonna be a widely encountered use case, and the various php versions are covered by the CI test matrix anyway.Let me know if you agree.
TODO