Include query_string in logs#384
Conversation
|
I didn't see any existing unit tests for logging and I wasn't sure how best to add them. Here's example output from my local development instance: |
|
I'm a little bit puzzled by these test failures: I can't replicate them in my local environment. |
|
Interesting thing I spotted while building the unit test: it looks like the ASGI specification makes it impossible to tell the difference between hits to |
|
Addressing the (unrelated) test failures you're seeing here: #385 |
|
And yes - ASGI can't see the '?' (WSGI either) If I'd have remembered that at the time I guess I might(?) have advocated for |
|
Alrighy - looks like if you merge master then those tests oughta start passing again. |
|
Hmm... that fixed the previous failures but I now have this one, which is also puzzling to me: |
|
Strange - also it's only occurring on the windows build. |
|
Or, eg. if you swap the two parameterization decorators around so that they're ordered the other way? |
|
Or if you swap the second one so that it's only running |
|
Swapping the order of the two parameterization decorators worked, great hunch there! |
|
Anything else we need to do before we can merge this? |
|
Released! 0.8.4 Thanks 🙏 |
https://github.com/encode/uvicorn/commits/0.8.4 Query strings will now be included in log files: Kludex/uvicorn#384
https://github.com/encode/uvicorn/commits/0.8.4 Query strings will now be included in log files: Kludex/uvicorn#384
https://github.com/encode/uvicorn/commits/0.8.4 Query strings will now be included in log files: Kludex/uvicorn#384
Refs #382