Moved FlowControl class and globals to its own file in uvicorn/protocols/http/#1034
Merged
euri10 merged 3 commits intoKludex:masterfrom May 27, 2021
Merged
Conversation
euri10
suggested changes
May 21, 2021
Author
|
@euri10 I have run the scripts/lint as mentioned and pushed the changes. |
euri10
approved these changes
May 27, 2021
Contributor
|
thanks a lot @ShahriyarR ! |
Vibhu-Agarwal
added a commit
to Vibhu-Agarwal/uvicorn
that referenced
this pull request
May 27, 2021
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
…ols/http/ (Kludex#1034) * Moved FlowControl class and globals to its own file * Run scripts/lint as requested in code review * Fixing import error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have spotted most of the parts of
h11_impl.pyandhttptools_impl.pyfiles are shared. The most notable duplication is FlowControl class and "constants", my suggestion is to move this part to separate fileflow_control.pyand then use it, this will reduce the duplicated code portion.