Fix precedence of explicit HEAD routes over implicit HEAD#3182
Open
Hedingber wants to merge 2 commits into
Open
Fix precedence of explicit HEAD routes over implicit HEAD#3182Hedingber wants to merge 2 commits into
Hedingber wants to merge 2 commits into
Conversation
naarob
pushed a commit
to naarob/starlette
that referenced
this pull request
Mar 26, 2026
…D route precedence (Kludex#3182) fix Kludex#3193: staticfiles.is_not_modified() used tag.strip(' W/') which operates on a character set, incorrectly trimming ETags ending in 'W' or '/'. Replaced with a normalize_etag() helper that uses str.startswith('W/') for prefix removal. fix Kludex#3182: Route.__init__ adds HEAD implicitly when GET is defined, causing the GET route to steal HEAD requests before any explicit HEAD route can match. Tracked _explicit_methods and return Match.PARTIAL for implicit HEAD so explicit HEAD routes registered at the same path can take precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the routing bug described in Discussion #3128.
Previously,
Routeadded"HEAD"to itsmethodslist when initialized withmethods=["GET"]. Because routing resolves sequentially viaMatch.FULL, aHEADrequest would trigger the implicitHEADfallback on a defaultGETroute rather than continuing the search for an explicitly tailoredHEADhandler mapped later in theRouter.This PR:
self.explicit_methodsto log methods genuinely passed during route initialization by the user.Match.PARTIALforHEADrequests occurring on routes that didn't intentionally list it inexplicit_methods. This politely passes routing scope further down the line to ensure realHEADhandlers still take precedence!Checklist