Merged
Conversation
Owner
|
(I'll rebase this on top of #2178, fyi) |
Contributor
Author
|
Would you like me to add an extra test job to test against both AnyIO 3.x and 4.x? There is no 4.x release available yet though, hence the git pointer in |
Kludex
reviewed
Jul 22, 2023
tests/middleware/test_wsgi.py
Outdated
| app = WSGIMiddleware(raise_exception) | ||
| client = test_client_factory(app) | ||
| with pytest.raises(RuntimeError): | ||
| with pytest.raises(RuntimeError), convert_excgroups(): |
Owner
There was a problem hiding this comment.
We can use the ExceptionGroup here. I'm fine with this break, since we intend to remove WSGIMiddleware.
| @@ -15,6 +15,8 @@ | |||
| from starlette.testclient import TestClient | |||
Owner
There was a problem hiding this comment.
I'd prefer if we maintain the tests unchanged, and unpack the ExceptionGroup on the BaseHTTPMiddleware in case we have a single exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates Starlette to work with AnyIO 4.0. Note that while this PR maintains compatibility with AnyIO 3.x, some of the new AnyIO behavior is likely to bleed through in some use cases at least.
Checklist