Skip to content

Support Debug extension#1991

Merged
Kludex merged 4 commits intomasterfrom
fix/add-debug-extension-support
Feb 6, 2023
Merged

Support Debug extension#1991
Kludex merged 4 commits intomasterfrom
fix/add-debug-extension-support

Conversation

@Kludex
Copy link
Owner

@Kludex Kludex commented Dec 30, 2022

@Kludex Kludex requested review from a team and adriangb December 30, 2022 14:22
@Kludex Kludex added this to the Version 0.24.0 milestone Jan 7, 2023
@Kludex
Copy link
Owner Author

Kludex commented Feb 4, 2023

@encode/maintainers I need a review here. 👀

@Kludex Kludex mentioned this pull request Feb 4, 2023
7 tasks
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great, congratulations on getting it standardized via the ASGI spec. I like the generality of it, too. Definitely a better state of things than the previous http.response.template extension!

@Kludex
Copy link
Owner Author

Kludex commented Feb 5, 2023

I think this is great, congratulations on getting it standardized via the ASGI spec. I like the generality of it, too. Definitely a better state of things than the previous http.response.template extension!

Thanks! 😁❤️

@Kludex Kludex merged commit ca1711f into master Feb 6, 2023
@Kludex Kludex deleted the fix/add-debug-extension-support branch February 6, 2023 05:31
aminalaee pushed a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError with middleware and TemplateResponse

2 participants