Add verbose return type hint to HTTPConnection.json method#1597
Closed
fisher60 wants to merge 1 commit intoKludex:masterfrom
Closed
Add verbose return type hint to HTTPConnection.json method#1597fisher60 wants to merge 1 commit intoKludex:masterfrom
fisher60 wants to merge 1 commit intoKludex:masterfrom
Conversation
The original return type hint here, `typing.Any`, is too vague. A more accurate and specific type hint can be added. Using `typing.Dict[str, typing.Any]` is more clear as this response should always be JSON, therefore `typing.Any` is misleading.
Owner
|
As shortly mentioned on #1596 (comment), this PR makes the wrong assumption. Thanks for the interested tho! |
mgorny
added a commit
to mgorny/starlette
that referenced
this pull request
Nov 22, 2022
Use a fake "text" Content-Encoding instead of "br" for test_gzip_ignored_for_responses_with_encoding_set. The latter currently fails if an implementation of brotli is actually installed, since the test uses fake content that is not valid Brotli stream. Rather than forcing a dependency on Brotli decoder, just use a custom Content-Encoding that should not yield any implicit processing. Closes Kludex#1597
Kludex
pushed a commit
that referenced
this pull request
Nov 23, 2022
aminalaee
pushed a commit
that referenced
this pull request
Feb 13, 2023
azurelotus06
added a commit
to azurelotus06/starlette
that referenced
this pull request
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original return type hint here,
typing.Any, is too vague. A more accurate and specific type hint can be added. Usingtyping.Dict[str, typing.Any]is more clear as this response should always be JSON, thereforetyping.Anyis misleading.Initially raised as discussion #1596