Skip to content

sync_heater and sync_extruder#4445

Closed
Tircown wants to merge 2 commits into
Klipper3d:masterfrom
Tircown:work-sync-extruder
Closed

sync_heater and sync_extruder#4445
Tircown wants to merge 2 commits into
Klipper3d:masterfrom
Tircown:work-sync-extruder

Conversation

@Tircown

@Tircown Tircown commented Jun 30, 2021

Copy link
Copy Markdown
Contributor

Add the ability to synchronize heaters temperatures with an optional offset.
Add the ability to synchronize extruders steppers and heaters with an optional offset.

This PR prepares duplication/mirror modes for IDEX printers. Even if this code is fully functional the PR is mainly for discussion about the best way to synchronize the extruders. Heaters synchronisation can eventually be used for big heatbed that use multiple heatpads.

Signed-off-by: Fabrice GALLET tircown@gmail.com

Tircown added 2 commits June 30, 2021 23:20
Synchronize heaters temperatures with an optional offset
Synchronize extruders steppers and heaters  with an optional offset
Typo
@devond76180

Copy link
Copy Markdown

Just tested this code. Works correctly. Have second heatbed set as C (so octoprint will show it). If heater_bed get there first waits for bed2. If bed2 gets there first waits for heater_bed.

command
sync_heater_temperature heater=bed2 to=heater_bed

heater_bed and heater_generic in config file

[heater_bed]
heater_pin: P2.5
sensor_type: EPCOS 100K B57560G104F
sensor_pin: P0.25
control: pid
pid_Kp: 171.72
pid_Ki: 31.76
pid_Kd: 619.01
min_temp: 0
max_temp: 130

[heater_generic bed2]
gcode_id:C
#The id to use when reporting the temperature in the M105 command.
#This parameter must be provided.
heater_pin: P2.4
#max_power:
sensor_type: EPCOS 100K B57560G104F
sensor_pin: P0.23
#smooth_time:
control: pid
pid_Kp: 171.72
pid_Ki: 31.76
pid_Kd: 619.01
#pwm_cycle_time:
min_temp: 0
max_temp: 130
#See the "extruder" section for the definition of the above
#parameters.

@Tircown

Tircown commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

Thank you for your feedback. Maybe it would be interesting to add attributes for heater_generic to synchronize when Klipper starts?

[heater_generic]
...
sync_heater: heater_bed
#sync_temp_offset: 0.

Is the temperature offset useful for your usage?
Can this/these parameters be useful for other heaters than [heater_generic]?

I prefer to wait for Kevin's comment before going further in this developpment.

@devond76180

devond76180 commented Jul 7, 2021 via email

Copy link
Copy Markdown

@KevinOConnor

Copy link
Copy Markdown
Collaborator

Thanks. FWIW, I'm not sure of the advantages of adding this code as opposed to using macros that obtain similar results. I'd expect that there is a relatively small audience of users that would want to synchronize heaters, and I expect those users have fairly custom setups that wont be easy to model with simple commands/config options. Those users may find macros easier as they explicitly state the actions to take on each request.

-Kevin

@devond76180

devond76180 commented Jul 13, 2021 via email

Copy link
Copy Markdown

@Tircown

Tircown commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

Thank you Kevin.
It's not a big deal to do the heater synchronisation in macro. @devond76180, for a heatbed, override M140 and M190 with macros. Use the "rename_existing" argument and as gcode, call the renamed M140/M190 and SET_HEATER_TEMPERATURE for the second heater. I should push macros samples soon in #4464 for the extruders that can help you.
The synchronization of the extruder steppers will still be missing. There is currently no solution for this.

@devond76180

devond76180 commented Jul 13, 2021 via email

Copy link
Copy Markdown

@Tircown

Tircown commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

In macro you can use the G-code command TEMPERATURE_WAIT. I agree with Kevin that the sync_heater part of this PR adds no feature. This only adds convenience.

@Tircown

Tircown commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

Replaced by PR #4489 for syncing of extruder steppers and macros for syncing of heaters.

@devond76180

devond76180 commented Jul 15, 2021 via email

Copy link
Copy Markdown

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants