BUG: Restore complex gesture support#109
Merged
jcfr merged 1 commit intoKitwareMedical:masterfrom Jan 30, 2023
Merged
Conversation
Following 1c36e40 (ENH: Update integration to support VTK 9.1), VTK was updated to a version where RecognizeComplexGesture was not virtual anymore in the base class (due to the integration of Kitware/VTK@af0fab486 (Clean up VR and OpenVR classes)). This commit re-introduces the support for custom complex gesture handling based of VTK MR-9892. See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9892 SlicerVirtualReality implementation details: * The implementation of both HandleGripEvents() and RecognizeComplexGesture() was updated by removing the handling specific to Rotate and Pan to only keep he pinch event. * The update of the Scale was removed. * Call to StartingPhysicalEventPoses() originally introduced though both SlicerVirtualReality@b6815f1cb and Kitware/VTK@803d3a327 was maintained. The PhysicalToWorld matrix is modified so that the controller physical pose corresponds to the same rendering world pose. * The lines either enclosed in `[SlicerVirtualReality]` or associated with a `// SlicerVirtualReality` comment are specific to this extension.
jcfr
added a commit
to jcfr/Slicer
that referenced
this pull request
Jan 30, 2023
…alReality References: * KitwareMedical/SlicerVirtualReality#109 * KitwareMedical/SlicerVirtualReality#91 List of changes: $ git shortlog 465e9dff6a..6efd97c519 --no-merges Jean-Christophe Fillion-Robin (1): [Backport MR-9892] ENH: Re-introduce support for custom logic handling VR complex gesture
jcfr
added a commit
to Slicer/Slicer
that referenced
this pull request
Jan 30, 2023
…alReality References: * KitwareMedical/SlicerVirtualReality#109 * KitwareMedical/SlicerVirtualReality#91 List of changes: $ git shortlog 465e9dff6a..6efd97c519 --no-merges Jean-Christophe Fillion-Robin (1): [Backport MR-9892] ENH: Re-introduce support for custom logic handling VR complex gesture
Contributor
Author
|
cc: @cpinter @LucasGandel |
jcfr
added a commit
to lassoan/Slicer
that referenced
this pull request
Feb 21, 2023
…alReality References: * KitwareMedical/SlicerVirtualReality#109 * KitwareMedical/SlicerVirtualReality#91 List of changes: $ git shortlog 465e9dff6a..6efd97c519 --no-merges Jean-Christophe Fillion-Robin (1): [Backport MR-9892] ENH: Re-introduce support for custom logic handling VR complex gesture
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following 1c36e40 (ENH: Update integration to support VTK 9.1), VTK was updated to a version where RecognizeComplexGesture was not virtual anymore in the base class (due to the integration of Kitware/VTK@af0fab486 (Clean up VR and OpenVR classes)).
This commit re-introduces the support for custom complex gesture handling based of VTK MR-9892.
See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9892
SlicerVirtualReality implementation details:
The implementation of both
HandleGripEvents()andRecognizeComplexGesture()was updated by removing the handling specific to Rotate and Pan to only keep he pinch event.The update of the Scale was removed.
Call to
StartingPhysicalEventPoses()originally introduced though both SlicerVirtualReality@b6815f1cb and Kitware/VTK@803d3a327 was maintained. ThePhysicalToWorldmatrix is modified so that the controller physical pose corresponds to the same rendering world pose.The lines either enclosed in
[SlicerVirtualReality]or associated with a// SlicerVirtualRealitycomment are specific to this extension.