Fix interaction support renaming VR interactor style callback functions#108
Merged
cpinter merged 1 commit intoKitwareMedical:masterfrom Feb 13, 2023
Merged
Conversation
Contributor
Author
|
@jcfr Please review |
cda0a3b to
fae1799
Compare
Contributor
Custom heuristic for handling complex gesture in SlicerVirtualReality has been restored in #109 through the backport of VTK MR-9892 to Slicer/VTK@slicer-v9.1.20220125-efbe2afc2 |
fae1799 to
443cbee
Compare
Contributor
|
@cpinter Since probably worked on this during the project week, I suggest we consolidate this with you work. |
This commit initiates renaming of the interactor style event callback functions to support the action based input model introduced in Slicer/VTK@b7f02e6 This commit adds support for Select3DEvent and ViewerMovement3DEvent. - Select3DEvent: The action performed when this event is fired is defined by calling MapInputToAction (see [1]). - ViewerMovement3DEvent: Gives users the ability to fly by calling Dolly3D(). VTK's interactor style offers additional behavior to move around. [1] https://gitlab.kitware.com/vtk/vtk/-/blob/master/Rendering/VR/vtkVRInteractorStyle.cxx#L61 Future commits could focus on: - Completing synchronization of this class with vtkVRInteractorStyle: . Add support for Grounded movement style for ViewerMovement3DEvent . Add support for Elevation3DEvent, Pick3DEvent, Clip3DEvent NextPose3DEvent, Menu3DEvent - Confirm that multi gesture events (Pan, Rotate and Pinch) are functional if pressing the grip buttons, and propose new approach to customize the gesture button in VTK. Multi-gesture is handled by the interactor but only triggered by grip buttons (see [2]). This deprecates the vtkVirtualRealityViewInteractor::SetGestureButtonTo*** function. [2] https://github.com/Slicer/VTK/blob/slicer-v9.1.20220125-efbe2afc2/Rendering/VR/vtkVRRenderWindowInteractor.cxx#L366
443cbee to
60fe85b
Compare
Contributor
Author
|
@cpinter confirmed this fixes the basic interactions. There are no noticeable improvements to add after the project week. |
Collaborator
|
Thanks a lot @LucasGandel ! |
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit initiates renaming of the interactor style event callback functions to support the action based input model introduced in Slicer/VTK@b7f02e6
This commit adds support for
Select3DEventandViewerMovement3DEvent.[1] https://gitlab.kitware.com/vtk/vtk/-/blob/master/Rendering/VR/vtkVRInteractorStyle.cxx#L61
Future commits could focus on:
Completing synchronization of this class with
vtkVRInteractorStyle:ViewerMovement3DEventElevation3DEvent,Pick3DEvent,Clip3DEvent,NextPose3DEvent,Menu3DEventConfirm that multi gesture events (Pan, Rotate and Pinch) are functional if pressing the grip buttons, and propose new approach to customize the gesture button in VTK. Multi-gesture is handled by the interactor but only triggered by grip buttons (see [2]). This deprecates the
vtkVirtualRealityViewInteractor::SetGestureButtonTofunction.[2] https://github.com/Slicer/VTK/blob/slicer-v9.1.20220125-efbe2afc2/Rendering/VR/vtkVRRenderWindowInteractor.cxx#L366