Merged
Conversation
Contributor
|
@tunniclm I think this should be ready to go if the package.swift gets updated ( |
8018e22 to
aea4890
Compare
Codecov Report
@@ Coverage Diff @@
## develop #9 +/- ##
===========================================
+ Coverage 64.04% 66.85% +2.81%
===========================================
Files 5 2 -3
Lines 712 175 -537
Branches 31 0 -31
===========================================
- Hits 456 117 -339
+ Misses 256 58 -198
Continue to review full report at Codecov.
|
Collaborator
Author
|
I'd rather do the SwiftyRequest update separately unless there's a reason why it is needed for this PR that I'm missing. |
Contributor
|
None that I was particularly thinking of. It was more just of a 'well, might as well' kinda thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for calling get on a route without providing an ID and getting a non-array Codable returned. This is the client counterpart to PR Kitura/Kitura#1176 and is also dependent on Kitura/KituraContracts#4.