Conversation
This was referenced Nov 13, 2017
rolivieri
suggested changes
Nov 13, 2017
Contributor
rolivieri
left a comment
There was a problem hiding this comment.
LG! Only minor change I would recommend is regenerating the Jazzy docs so they have this new closure alias (I missed doing this for my PR too).
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 28.26% 28.26%
=======================================
Files 1 1
Lines 92 92
=======================================
Hits 26 26
Misses 66 66
Continue to review full report at Codecov.
|
Collaborator
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow Kitura to loosen up the Codable routes that apply to a
router.getwithout identifier.See PR Kitura/Kitura#1176