Conversation
ianpartridge
requested changes
Apr 10, 2018
Contributor
ianpartridge
left a comment
There was a problem hiding this comment.
We still need to test on Swift 4.0.3
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 9 9
Lines 495 495
=======================================
Hits 453 453
Misses 42 42
Continue to review full report at Codecov.
|
.travis.yml
Outdated
| osx_image: xcode9.2 | ||
| sudo: required | ||
|
|
||
| env: SWIFT_SNAPSHOT=swift-4.0.3-RELEASE |
Contributor
There was a problem hiding this comment.
I think this should be env: SWIFT_SNAPSHOT=4.0.3.
.travis.yml
Outdated
| osx_image: xcode9.2 | ||
| sudo: required | ||
|
|
||
| env: SWIFT_SNAPSHOT=swift-4.0.3 |
Contributor
There was a problem hiding this comment.
Nope: env: SWIFT_SNAPSHOT=4.0.3
ianpartridge
approved these changes
Apr 11, 2018
djones6
suggested changes
Apr 12, 2018
| @@ -21,10 +21,13 @@ matrix: | |||
| - os: linux | |||
| dist: trusty | |||
| sudo: required | |||
Contributor
There was a problem hiding this comment.
Can we also define a Linux build with Swift 4.0.3?
dd31ccf to
2edfa98
Compare
Contributor
|
LGTM - @djones6 please review and merge if happy. |
djones6
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.