Revert "Relax Codable Router type requirements"#1269
Merged
Conversation
This reverts commit 91f47de.
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
==========================================
- Coverage 88.21% 88.17% -0.04%
==========================================
Files 38 38
Lines 2385 2377 -8
==========================================
- Hits 2104 2096 -8
Misses 281 281
Continue to review full report at Codecov.
|
ianpartridge
approved these changes
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts #1242.
Motivation and Context
We've found a problem with the relaxing of output types from
CodabletoEncodable, such that they are no longer compatible with the TypeDecoder.We need to revert the relaxing of types so that TypeDecoder can be used with the types used by Codable routes. Unfortunately, this means #1235 is no longer resolved and should be reopened. We'll still aim to reintroduce this in the future once a solution can be found.
Note - depends on Kitura/KituraContracts#22
How Has This Been Tested?
Checklist: