Revert "Relax type constraints to Encodable and Decodable"#22
Merged
Conversation
This reverts commit 72cbab5.
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
====================================
Coverage 82% 82%
====================================
Files 6 6
Lines 489 489
====================================
Hits 401 401
Misses 88 88
Continue to review full report at Codecov.
|
ianpartridge
approved these changes
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #18.
We've found a problem with the relaxing of output types from
CodabletoEncodable, such that they are no longer compatible with the TypeDecoder.We need to revert the relaxing of types so that TypeDecoder can be used with the types used by Codable routes. We'll aim to reintroduce this in the future once a solution can be found.