Implementation of CodableResultClosure with QueryParameters#1253
Implementation of CodableResultClosure with QueryParameters#1253ianpartridge merged 1 commit intoKitura:masterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
==========================================
+ Coverage 89.04% 89.08% +0.03%
==========================================
Files 38 38
Lines 2292 2300 +8
==========================================
+ Hits 2041 2049 +8
Misses 251 251
Continue to review full report at Codecov.
|
db90043 to
41b156a
Compare
| @@ -39,7 +39,8 @@ class TestCodableRouter: KituraTest { | |||
| ("testRouteParameters", testRouteParameters), | |||
| ("testCodableRoutesWithBodyParsingFail", testCodableRoutesWithBodyParsingFail), | |||
| ("testCodableGetQueryParameters", testCodableGetQueryParameters), | |||
There was a problem hiding this comment.
Please rename this test to "testCodableGetSingleQueryParameters", then follow it with your new "testCodableGetArrayQueryParameters" test, then finish the array with the existing "testCodableDeleteQueryParameters" test.
That way the test naming is consistent with the non-queryparams cases.
41b156a to
1b156c3
Compare
|
@ianpartridge I have renamed the new test case to |
|
@saiHemak is this ready to merge? |
5d39476 to
767795d
Compare
|
@djones6 Changes were approved.Can you please merge |
In this PR I am implementing the support for CodableResultClosure with QueryParameters
Description
At the moment the router handler forces the users to use the CodableArrayResultClosure type only. Compilation fails if the application is expecting a Simple Codable type with QueryParameters.
Motivation and Context
Application needs a Simple JSON object instead of Array of JSON objects.As the current implementation does not allow a SimpleCodable type to be returned , I have implemented the same.
How Has This Been Tested?
Ran Kitura test-suite with my changes
Checklist: