Toast on error in mlEphantManagerMachine#8148
Merged
pierremtb merged 7 commits intoconversational-ttcfrom Aug 29, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacebrowning
approved these changes
Aug 28, 2025
Contributor
There was a problem hiding this comment.
This seems reasonable to me, but the snapshot image appears to be incorrect.
I'd suggest something like first deleting the "Update snapshots" commits from conversational-ttc and rebasing that on main, then deleting the "Update snapshots" commits from this branch and rebasing it on conversational-ttc, then merging into it.
jacebrowning
pushed a commit
that referenced
this pull request
Aug 29, 2025
* pierremtb/issue8087-toast-on-error * Update snapshots * Update to have only the message in the particular error I was looking at * Update snapshots * Reset snaps * Dumb me this ain't main --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jacebrowning
added a commit
that referenced
this pull request
Sep 4, 2025
* Revert "Revert TTC Conversational UX commits (#8149)" This reverts commit 42f1265. * To revert: build release with codesign * Toast on error in mlEphantManagerMachine (#8148) * pierremtb/issue8087-toast-on-error * Update snapshots * Update to have only the message in the particular error I was looking at * Update snapshots * Reset snaps * Dumb me this ain't main --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update snapshots * Allow user to select text within prompt cards * Add dark mode theming to thinking components * Focus textarea on click of bottom of submit area * Remove Prompts tab from home page (for now) (#8204) Remove Prompts tab from Home * Revert "To revert: build release with codesign" This reverts commit c3680e0. * Fix project id -> convo id association and switching * Make the "See reasoning" visibility be powered by CSS hovers * Use the new types * Make errors and code show up nicely and scrollable * Use absolute positioning on the show reasoning button So that the bbox doesn't jump around due to text disappeating and whatnot * Add back that flex-end so reasoning text is right-aligned again --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jace Browning <jacebrowning@gmail.com> Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com> Co-authored-by: Frank Noirot <frankjohnson1993@gmail.com> Co-authored-by: lee-at-zoo-corp <lee@zoo.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't solving #8087 but we should bubble up something outside of the console to make sure they understand it's not working as intended.