Inliner: Fix LoopMerge when inline into loop header of multi block loop#801
Merged
dneto0 merged 1 commit intoKhronosGroup:masterfrom Sep 5, 2017
Merged
Inliner: Fix LoopMerge when inline into loop header of multi block loop#801dneto0 merged 1 commit intoKhronosGroup:masterfrom
dneto0 merged 1 commit intoKhronosGroup:masterfrom
Conversation
Collaborator
Author
|
Another review request for @greg-lunarg. |
This adapts the fix for the single-block loop. Split the loop like before. But when we move the OpLoopMerge back to the loop header, redirect the continue target only when the original loop was a single block loop. Fixes KhronosGroup#800
Collaborator
Author
|
Rebased and added CHANGES entry. |
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
This does not appear to be standard practice. The results of these checks would only change if the compiler itself changes, so checking it on everyrun is unnecessary. Fixes KhronosGroup#773
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adapts the fix for the single-block loop. Split the loop like
before. But when we move the OpLoopMerge back to the loop header,
redirect the continue target only when the original loop was a single
block loop.
Fixes #800