Correctly replace debug lexical scope of instruction#3718
Merged
jaebaek merged 5 commits intoKhronosGroup:masterfrom Aug 31, 2020
Merged
Correctly replace debug lexical scope of instruction#3718jaebaek merged 5 commits intoKhronosGroup:masterfrom
jaebaek merged 5 commits intoKhronosGroup:masterfrom
Conversation
When we update OpenCL.DebugInfo.100 lexical scopes e.g., DebugFunction, we have to replace DebugScope of each instruction that uses the lexical scope correctly.
19a3c5f to
6ef3f42
Compare
s-perron
requested changes
Aug 20, 2020
source/opt/ir_context.h
Outdated
| } | ||
| } | ||
|
|
||
| // Updates DebugScope and line of |inst| and analyzes use information |
Collaborator
There was a problem hiding this comment.
You can update the analysis in Instruction::UpdateDebugInfoFrom. The instruction class has access to the context.
source/opt/ir_context.h
Outdated
|
|
||
| // Updates DebugInlinedAt of |inst| and analyzes use information | ||
| // of DebugInlinedAt. | ||
| void UpdateDebugInlinedAt(Instruction* inst, uint32_t dbg_inlined_at) { |
Collaborator
There was a problem hiding this comment.
I don't think you need this function. You can move the update of the debug info manager to the instruction classes version of the function.
jaebaek
commented
Aug 21, 2020
Contributor
Author
jaebaek
left a comment
There was a problem hiding this comment.
Thank you for code review. PTAL!
source/opt/ir_context.h
Outdated
|
|
||
| // Updates DebugInlinedAt of |inst| and analyzes use information | ||
| // of DebugInlinedAt. | ||
| void UpdateDebugInlinedAt(Instruction* inst, uint32_t dbg_inlined_at) { |
source/opt/ir_context.h
Outdated
| } | ||
| } | ||
|
|
||
| // Updates DebugScope and line of |inst| and analyzes use information |
s-perron
approved these changes
Aug 26, 2020
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
Roll third_party/glslang/ 983698b..517f39e (1 commit) KhronosGroup/glslang@983698b...517f39e $ git log 983698b..517f39e --date=short --no-merges --format='%ad %ae %s' 2020-08-26 jmadill Suppress two override suggestion warnings. Created with: roll-dep third_party/glslang Roll third_party/googletest/ 1e315c5b1..df6b75949 (1 commit) google/googletest@1e315c5...df6b759 $ git log 1e315c5b1..df6b75949 --date=short --no-merges --format='%ad %ae %s' 2020-08-26 absl-team Googletest export Created with: roll-dep third_party/googletest Roll third_party/spirv-tools/ 4dd1223..8a0ebd4 (14 commits) KhronosGroup/SPIRV-Tools@4dd1223...8a0ebd4 $ git log 4dd1223..8a0ebd4 --date=short --no-merges --format='%ad %ae %s' 2020-08-31 jaebaek Correctly replace debug lexical scope of instruction (KhronosGroup#3718) 2020-08-28 afdx spirv-fuzz: Remove opaque pointer design pattern (KhronosGroup#3755) 2020-08-27 stefanomil spirv-fuzz: Create synonym via OpPhi and existing synonyms (KhronosGroup#3701) 2020-08-27 stefanomil Add LoopNestingDepth function to StructuredCFGAnalysis (KhronosGroup#3754) 2020-08-27 afdx spirv-fuzz: Do not make synonyms of void result ids (KhronosGroup#3747) 2020-08-26 greg Do not register DebugFunction for functions optimized away. (KhronosGroup#3749) 2020-08-26 jaebaek Handle DebugScope in compact-ids pass (KhronosGroup#3724) 2020-08-26 afdx spirv-fuzz: Overflow ids (KhronosGroup#3734) 2020-08-25 greg Fix DebugNoScope to not output InlinedAt operand. (KhronosGroup#3748) 2020-08-25 vasniktel spirv-fuzz: Split the fact manager into multiple files (KhronosGroup#3699) 2020-08-25 andreperezmaselco.developer spirv-fuzz: Add inline function transformation (KhronosGroup#3517) 2020-08-25 vasniktel spirv-fuzz: Fix MaybeGetZeroConstant (KhronosGroup#3740) 2020-08-24 greg Fix SSA-rewrite to remove DebugDeclare for variables without loads (KhronosGroup#3719) 2020-08-24 stevenperron Add undef for inlined void function (KhronosGroup#3720) Created with: roll-dep third_party/spirv-tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we update OpenCL.DebugInfo.100 lexical scopes e.g., DebugFunction,
we have to replace DebugScope of each instruction that uses the lexical
scope correctly.