spirv-fuzz: Check integer and float width capabilities#3670
Conversation
There was a problem hiding this comment.
I don't think we should add capabilities. This may cause the shader to violate the spec when run because the host application also usually needs to request certain extensions or features. We (usually) want to make sure we can inject the fuzzed shader into the original application without violating the spec. Thus, it might be better to assert that the capabilities must exist and also fix the calling code to only consider 16 or 64 bit floats when the capability is present.
774f61f to
25b0b5f
Compare
|
It would be good to add simple tests. |
paulthomson
left a comment
There was a problem hiding this comment.
Very nice. I agree that it would be good to add some very basic tests. Also, could you please make a similar change in TransformationAddTypeInt::IsApplicable?
25b0b5f to
3d1ad49
Compare
paulthomson
left a comment
There was a problem hiding this comment.
Really nice! Thanks for the tests. I have one minor suggestion that will ensure we don't let a different width slip through in the future. No need to update the tests in my opinion.
3d1ad49 to
3d376c4
Compare
paulthomson
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
…3670) `TransformationAddTypeFloat` and `TransformationAddTypeInt` did not check whether the required capabilities were present when adding 16-bit, 64-bit, and 8-bit types. This change adds these checks in the `IsApplicable` method of each transformation. Fixes KhronosGroup#3669.
Roll third_party/glslang/ b60e067..f257e0e (11 commits) KhronosGroup/glslang@b60e067...f257e0e $ git log b60e067..f257e0e --date=short --no-merges --format='%ad %ae %s' 2020-08-14 john Build: fix a build warning 2020-08-14 rafael.fariasmarinheiro Use --test-root to pass files to Bazel tests. 2020-08-14 john Fix KhronosGroup#2366, fix KhronosGroup#2358, correctly separate out numerical feature checking 2020-08-14 john Non-functional (almost): Refactor when 'extensionRequested' is called. 2020-08-14 john Non-functional: Remove reinventing the scalar type, note code issues 2020-08-11 john Non-functional: spellings of "destinaton" and "addPairConversion" 2020-08-12 alanbaker Update test expectations 2020-08-12 alanbaker Update SPIRV-Tools and SPIRV-Headers known good 2020-08-10 ezdiy GLSLANG_EXPORT for C APIs. 2020-08-07 john Non-functional: correctly do GL_EXT_buffer_reference2 semantic checking 2020-08-06 john Non-functional: consistently use 'const TSourceLoc&' to pass location. Created with: roll-dep third_party/glslang Roll third_party/googletest/ 3af06fe16..adeef1929 (4 commits) google/googletest@3af06fe...adeef19 $ git log 3af06fe16..adeef1929 --date=short --no-merges --format='%ad %ae %s' 2020-08-12 krzysio Googletest export 2020-08-11 absl-team Googletest export 2020-08-11 dmauro Googletest export 2020-08-10 absl-team Googletest export Created with: roll-dep third_party/googletest Roll third_party/spirv-cross/ 82d1c43e4..4c7944bb4 (1 commit) KhronosGroup/SPIRV-Cross@82d1c43...4c7944b $ git log 82d1c43e4..4c7944bb4 --date=short --no-merges --format='%ad %ae %s' 2020-08-13 lehoangq Fix KhronosGroup#1445: MSL: Enclose args when convert distance(a,b) to abs(a-b) Created with: roll-dep third_party/spirv-cross Roll third_party/spirv-tools/ 2990a21..b8de4f5 (19 commits) KhronosGroup/SPIRV-Tools@2990a21...b8de4f5 $ git log 2990a21..b8de4f5 --date=short --no-merges --format='%ad %ae %s' 2020-08-16 jaebaek Allow DebugTypeTemplate for Type operand (KhronosGroup#3702) 2020-08-14 antonikarp spirv-fuzz: Improve code coverage of tests (KhronosGroup#3686) 2020-08-14 stefanomil spirv-fuzz: Fuzzer pass to randomly apply loop preheaders (KhronosGroup#3668) 2020-08-14 vasniktel spirv-fuzz: Support identical predecessors in TransformationPropagateInstructionUp (KhronosGroup#3689) 2020-08-13 alanbaker Improve non-semantic instruction handling in the optimizer (KhronosGroup#3693) 2020-08-13 vasniktel Fix the bug (KhronosGroup#3680) 2020-08-12 andreperezmaselco.developer spirv-fuzz: Check integer and float width capabilities (KhronosGroup#3670) 2020-08-12 andreperezmaselco.developer spirv-fuzz: consider additional access chain instructions (KhronosGroup#3672) 2020-08-12 andreperezmaselco.developer spirv-fuzz: Ignore specialization constants (KhronosGroup#3664) 2020-08-12 vasniktel Fix the bug (KhronosGroup#3683) 2020-08-12 vasniktel spirv-fuzz: Fix width in FuzzerPassAddEquationInstructions (KhronosGroup#3685) 2020-08-12 jaebaek Preserve debug info in dead-insert-elim pass (KhronosGroup#3652) 2020-08-12 jaebaek Validate more OpenCL.DebugInfo.100 instructions (KhronosGroup#3684) 2020-08-11 alanbaker Only validation locations for appropriate execution models (KhronosGroup#3656) 2020-08-11 andreperezmaselco.developer spirv-fuzz: Fix in operand type assertion (KhronosGroup#3666) 2020-08-11 andreperezmaselco.developer spirv-opt: Add spvOpcodeIsAccessChain (KhronosGroup#3682) 2020-08-11 vasniktel spirv-fuzz: FuzzerPassPropagateInstructionsUp (KhronosGroup#3478) 2020-08-10 stevenperron Handle no index access chain in local access chain convert (KhronosGroup#3678) 2020-08-10 rharrison Roll 2 dependencies (KhronosGroup#3677) Created with: roll-dep third_party/spirv-tools
TransformationAddTypeFloatandTransformationAddTypeIntdid not check whether the required capabilities were present when adding 16-bit, 64-bit, and 8-bit types.This change adds these checks in the
IsApplicablemethod of each transformation.Fixes #3669.