spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory#3586
Merged
afd merged 10 commits intoKhronosGroup:masterfrom Jul 27, 2020
Merged
Conversation
added 2 commits
July 24, 2020 10:33
paulthomson
reviewed
Jul 24, 2020
Contributor
paulthomson
left a comment
There was a problem hiding this comment.
This looks very good. I have added some comments.
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.h
Outdated
Show resolved
Hide resolved
source/fuzz/transformation_replace_load_store_with_copy_memory.cpp
Outdated
Show resolved
Hide resolved
paulthomson
reviewed
Jul 24, 2020
paulthomson
reviewed
Jul 24, 2020
Contributor
paulthomson
left a comment
There was a problem hiding this comment.
This is really good! Added a few more comments.
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/fuzzer_pass_replace_loads_stores_with_copy_memories.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/transformation_replace_load_store_with_copy_memory.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/transformation_replace_load_store_with_copy_memory.cpp
Outdated
Show resolved
Hide resolved
source/fuzz/transformation_replace_load_store_with_copy_memory.h
Outdated
Show resolved
Hide resolved
test/fuzz/transformation_replace_load_store_with_copy_memory_test.cpp
Outdated
Show resolved
Hide resolved
afd
approved these changes
Jul 27, 2020
dnovillo
pushed a commit
to dnovillo/SPIRV-Tools
that referenced
this pull request
Aug 19, 2020
…sGroup#3586) Adds a transformation that takes a pair of instruction descriptors to OpLoad and OpStore that have the same intermediate value and replaces the OpStore with an equivalent OpCopyMemory. Fixes KhronosGroup#3353.
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
* Rolling 2 dependencies and updating expectations Roll third_party/spirv-cross/ 6575e451f..0376576d2 (5 commits) KhronosGroup/SPIRV-Cross@6575e45...0376576 $ git log 6575e451f..0376576d2 --date=short --no-merges --format='%ad %ae %s' 2020-07-22 tommek Enabling setting a fixed sampleMask in Metal fragment shaders. 2020-02-20 cdavis MSL: Add support for processing more than one patch per workgroup. 2020-07-22 dsinclair Roll GLSLang, SPIRV-Headers and SPIRV-Tools. 2020-07-22 cdavis MSL: Factor creating a uint type into its own method. 2020-07-22 cdavis MSL: Factor a really gnarly condition into its own method. Created with: roll-dep third_party/spirv-cross Roll third_party/spirv-tools/ 969f028..b63f0e5 (13 commits) KhronosGroup/SPIRV-Tools@969f028...b63f0e5 $ git log 969f028..b63f0e5 --date=short --no-merges --format='%ad %ae %s' 2020-07-27 rdb Fix SyntaxWarning in Python 3.8 (KhronosGroup#3388) 2020-07-27 bclayton CMake: Enable building with BUILD_SHARED_LIBS=1 (KhronosGroup#3490) 2020-07-27 dneto Avoid operand type range checks (KhronosGroup#3379) 2020-07-27 jaebaek Preserve debug info in scalar replacement pass (KhronosGroup#3461) 2020-07-27 pierremoreau Update OpenCL capabilities validation (KhronosGroup#3149) 2020-07-27 stevenperron build(deps): bump lodash from 4.17.15 to 4.17.19 in /tools/sva (KhronosGroup#3596) 2020-07-27 antonikarp spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory (KhronosGroup#3586) 2020-07-27 jaebaek Preserve OpenCL.DebugInfo.100 through private-to-local pass (KhronosGroup#3571) 2020-07-27 stefanomil spirv-fuzz: Relax type checking for int contants (KhronosGroup#3573) 2020-07-27 stefanomil spirv-fuzz: Generalise transformation access chain (KhronosGroup#3546) 2020-07-27 stefanomil spirv-fuzz: Split blocks starting with OpPhi before trying to outline (KhronosGroup#3581) 2020-07-27 afdx spirv-fuzz: Set message consumer in replayer when shrinking (KhronosGroup#3591) 2020-07-24 vasniktel spirv-fuzz: Don't use default parameters (KhronosGroup#3583) Created with: roll-dep third_party/spirv-tools * Add in missing expectations update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a transformation that takes a pair of instruction descriptors to
OpLoad and OpStore that have the same intermediate value and replaces
the OpStore with an equivalent OpCopyMemory.
Fixes #3353