Remove names and decorations of imported symbols#3081
Merged
s-perron merged 2 commits intoKhronosGroup:masterfrom Jan 10, 2020
Merged
Remove names and decorations of imported symbols#3081s-perron merged 2 commits intoKhronosGroup:masterfrom
s-perron merged 2 commits intoKhronosGroup:masterfrom
Conversation
Collaborator
|
Please add a test to check this change in functionality. Also I'd like @pierremoreau's opinion. |
Contributor
Author
|
I've added a test case to the PR. Let me know if anything else needs to be modified. |
Contributor
|
And sorry for never sending the patch. :-/ |
Contributor
|
@aqnuep Could you please rebase the series on the latest master? It includes the fix for the check-format test, which is currently failing on code unrelated to your MR. |
6cfe6e5 to
e671348
Compare
Contributor
Author
|
Done! |
Contributor
Contributor
|
If there are no other comments on this merge request, could someone please merge it (as I do not have write access to the repository myself)? Thanks in advance. |
Contributor
|
Thank you Steven for merging. 🙂 |
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
Roll third_party/glslang/ 40801e3..d203754 (6 commits) KhronosGroup/glslang@40801e3...d203754 $ git log 40801e3..d203754 --date=short --no-merges --format='%ad %ae %s' 2020-01-07 cepheus Fix KhronosGroup#1829: Add "--" command-line options for macro def/undef. 2020-01-08 laddoc Move symbol builtin check to grammar stage 2020-01-06 lryer Add missing extension defination 2019-11-26 laddoc Add support for ARB_gpu_shader_fp64 2020-01-03 lryer Fix glslang can't link multiple AST in a single stage 2019-12-25 laddoc Modify atomic_uint binding check Roll third_party/googletest/ 306f3754a..d854bd6ac (4 commits) google/googletest@306f375...d854bd6 $ git log 306f3754a..d854bd6ac --date=short --no-merges --format='%ad %ae %s' 2020-01-09 absl-team Googletest export 2020-01-09 absl-team Googletest export 2020-01-07 absl-team Googletest export 2020-01-07 absl-team Googletest export Roll third_party/re2/ 00af5b44d..85c014206 (2 commits) google/re2@00af5b4...85c0142 $ git log 00af5b44d..85c014206 --date=short --no-merges --format='%ad %ae %s' 2020-01-12 junyer Tidy up a test. 2020-01-07 junyer Prevent ShortVisit() from crashing fuzzers. Roll third_party/spirv-cross/ 961b9014a..172e39f03 (14 commits) KhronosGroup/SPIRV-Cross@961b901...172e39f $ git log 961b9014a..172e39f03 --date=short --no-merges --format='%ad %ae %s' 2020-01-09 post HLSL: Add a resource remapping API similar to MSL. 2020-01-09 post MSL: Deal with sign on wave min/max. 2020-01-09 post HLSL: Deal with casting for WaveActiveMin/Max. 2020-01-09 post GLSL: Deal with sign in subgroup Min/Max operations. 2020-01-08 post Run format_all.sh. 2020-01-08 post HLSL: Fix bug when reading and writing structs from SSBO. 2020-01-08 post HLSL: Implement stores for complex composites in ByteAddressBuffers. 2020-01-08 post HLSL: Support loading complex composites from ByteAddressBuffer. 2020-01-08 post Run format_all.sh. 2020-01-07 post MSL: Deal with padded fragment output + Component decoration. 2020-01-07 post MSL: Explicitly don't support component packing for tessellation. 2020-01-07 post MSL: Don't set OrigID when emitting component packed vectors. 2020-01-07 post MSL: Deal with packing vectors for vertex input/fragment output. 2020-01-07 post MSL: Add trivial tests for Component decoration. Roll third_party/spirv-tools/ c8bf143..18b3b94 (6 commits) KhronosGroup/SPIRV-Tools@c8bf143...18b3b94 $ git log c8bf143..18b3b94 --date=short --no-merges --format='%ad %ae %s' 2020-01-10 33791085+aqnuep Remove names and decorations of imported symbols (KhronosGroup#3081) 2020-01-08 dneto Fix GN build for OpenCL.DebugInfo.100 update (KhronosGroup#3134) 2020-01-08 bclayton Fix bad parameter names in error message (KhronosGroup#3129) 2020-01-07 alanbaker Revert PR KhronosGroup#3093 (KhronosGroup#3131) 2020-01-07 alanbaker Disallow forward references in arrays (KhronosGroup#3093) 2020-01-07 afdx spirv-fuzz: Add fuzzer pass to perform module donation (KhronosGroup#3117) Created with: roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be no reason to keep the original variable/function/parameter decorations around for import symbols, as the corresponding exports should either match them or should override them. At least that's my understanding, but if there are any exceptions to that please let me know.
Also, with this change the generated module won't have stale decoration and name instructions referring to ids which no longer exist after linking.