Don't merge unreachable blocks#2375
Merged
alan-baker merged 1 commit intoKhronosGroup:masterfrom Feb 12, 2019
Merged
Conversation
Fixes KhronosGroup#2374 * Block merging no longer merges unreachable blocks into their successors * added a test
paulthomson
reviewed
Feb 12, 2019
s-perron
approved these changes
Feb 12, 2019
afd
pushed a commit
to afd/SPIRV-Tools
that referenced
this pull request
Feb 13, 2019
Fixes KhronosGroup#2374 * Block merging no longer merges unreachable blocks into their successors * added a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2374
successors
Doesn't use
Dominatesbecause the blocks are unreachable.