Fix merge blocks opportunity to check if still enabled#2370
Merged
dneto0 merged 2 commits intoKhronosGroup:masterfrom Feb 11, 2019
Merged
Fix merge blocks opportunity to check if still enabled#2370dneto0 merged 2 commits intoKhronosGroup:masterfrom
dneto0 merged 2 commits intoKhronosGroup:masterfrom
Conversation
…enabled Fixes KhronosGroup#2369. Added tests.
afd
suggested changes
Feb 11, 2019
Contributor
afd
left a comment
There was a problem hiding this comment.
Looks good; just a request for a comment.
| bool MergeBlocksReductionOpportunity::PreconditionHolds() { | ||
| // By construction, it is not possible for the merging of A->B to disable the | ||
| // merging of C->D, even when B and C are the same block. | ||
| return true; |
Contributor
There was a problem hiding this comment.
It would be good to have a comment explaining that there do exist scenarios where one merge can disable another merge. Giving one example would help.
Contributor
Author
There was a problem hiding this comment.
Sounds good. Done.
| CheckEqual(env, after, context.get()); | ||
| } | ||
|
|
||
| void MergeBlocksReductionPassTest_LoopReturn_Helper(bool reverse) { |
Contributor
There was a problem hiding this comment.
Great that we have this example in the tests. Still, a comment in the precondition checking code would be good.
afd
pushed a commit
to afd/SPIRV-Tools
that referenced
this pull request
Feb 13, 2019
…2370) Fix MergeBlocksReductionOpportunity so it checks whether it is still enabled Fixes KhronosGroup#2369. Added tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2369. Added tests.