Update diag() calls in validate_capability.#1759
Merged
dj2 merged 3 commits intoKhronosGroup:masterfrom Aug 1, 2018
dj2:diag_08
Merged
Update diag() calls in validate_capability.#1759dj2 merged 3 commits intoKhronosGroup:masterfrom dj2:diag_08
dj2 merged 3 commits intoKhronosGroup:masterfrom
dj2:diag_08
Conversation
This CL updates the diag() call in validate_capability to provide the instruction.
alan-baker
approved these changes
Aug 1, 2018
s-perron
added a commit
to s-perron/SPIRV-Tools
that referenced
this pull request
Jul 24, 2019
When there is an OpDecorateId instruction that is live, the ids that is references must be kept live. This change adds them to the worklist. I've also updated a validator check to allow OpDecorateId to be able to apply to decoration groups. Fixes KhronosGroup#1759.
s-perron
added a commit
that referenced
this pull request
Jul 24, 2019
* Process OpDecorateId in ADCE When there is an OpDecorateId instruction that is live, the ids that is references must be kept live. This change adds them to the worklist. I've also updated a validator check to allow OpDecorateId to be able to apply to decoration groups. Fixes #1759. * Remove dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL updates the diag() call in validate_capability to provide the
instruction.