SPIR-V Environment Spec Refactor#84
Merged
alycm merged 4 commits intoKhronosGroup:masterfrom Jun 14, 2019
Merged
Conversation
kpet
requested changes
Jun 4, 2019
Contributor
kpet
left a comment
There was a problem hiding this comment.
We probably want to say explicitly that the Int64Atomics capability is required when cl_khr_int64_{base,extended}_atomics are present.
Otherwise looks generally good apart from a few typos. Thanks for doing this.
Contributor
Author
kpet
approved these changes
Jun 5, 2019
Contributor
|
Thanks! Well-spotted.Yes, it shouldn't hold up this PR (commenting on the Int64Atomics capability was already a bit of a stretch). |
alycm
approved these changes
Jun 14, 2019
Contributor
alycm
left a comment
There was a problem hiding this comment.
I didn't see unintentional changes, and the built version seems easier to follow with less duplication than the previous approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the SPIR-V environment spec to increase readability, reduce duplicated information, and break the tight coupling between an OpenCL version and the SPIR-V version(s) it supports.
I've fixed a few bugs as well, see #80 and #81.