Add Subgroup to the list of valid Memory Scopes for 2.1/2.2#80
Add Subgroup to the list of valid Memory Scopes for 2.1/2.2#80kpet wants to merge 1 commit intoKhronosGroup:masterfrom
Conversation
|
I think there is an issue here, but I wonder if this is the wrong fix. For OpenCL 2.1 or newer, or any implementation supporting subgroups, couldn't Subgroup be a valid Scope for Memory? It would correspond to an atomic with |
|
Agree this is missing. I was planning to deal with all the subgroup-related issues later but this was probably a bad idea :). I'll repurpose this PR to add the missing Subgroup Scope and look into reorganising the rules and solving the other issues later instead. |
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
8b161f3 to
7a1942e
Compare
Heads up, I'm already about halfway through refactoring these parts of the environment spec already, for other reasons (see internal issue 156). I appreciate the help, but let's be sure we aren't duplicating work - thanks! |
|
Right, hadn't caught up with it yet. I will pause work on the environment spec until you're done with that. Do you want to get this in or would you rather I close it? |
Signed-off-by: Kevin Petit kevin.petit@arm.com