CI and Build Improvements #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

MarkCallow merged 50 commits into main from rm_vs2015

Apr 15, 2023

Collaborator

MarkCallow commented Apr 15, 2023 •

edited

Loading

Remove VS2015 build from CI.
Move Windows builds (except VS2017) to GitHub Actions.
Run Windows builds and tests with both MSVC and CLangCL.
Build Windows release packages with VS2022 and CLangCL.
Turn on warnings as errors. Fix bug that prevented /W4 for CLangCL. Fix all warnings.
Update the included zstd.c and regen golden images for affected tests.
Stop using deprecated code in GitHub Actions.
Update Linux CI runner to Ubuntu Jammy
Update Vulkan SDK used in Linux and Windows CI to 1.3.243.
Fix issue with Doxygen builds that caused intermittent failures.

MarkCallow added 30 commits

April 9, 2023 13:52


          Remove VS2015 from CI. Add VS2022 to GH Actions.

31c59db

Move VS2019 build to Actions and do configuration check builds
with VS2022 not VS2019.

Includes:

 * Convert install_win.bat to install_win.ps1.

 * Increase DISCOVERY_TIMEOUT on all gtest_discover_tests to avoid
   flakiness in Actions.

 * Download VulkanSDK to $env:TEMP instead of C:/.

 * Remove incorrect "COMPONENTS" from FindJNI.


          Cleanup scripts and YAML.

157d732


          Only look for OpenCL if BASISU_SUPPORT_OPENCL set.

b72c7b5


          Add defaults for local builds.

58482ea


          Update default generator to VS2022.

d841b41


          Build with C++17 so MAYBE_UNUSED can work in VS2022.

1134c36


          Add CLangCL build for x64.

462b5fd


          Set -Wno-bitwise-instead-of-logical for zstd.c.

1e045cb


          Fix setting of warning disables for Clang warnings.

5ec9f84


          Remove debug messages.


          Treat warnings as errors.

0e20c6c


          Ignore warning from uint32_t cast template.

bee7f91


          Fix Apple M2 build warnings and failing test builds.

913ff6e


          Fix merged code using old function name.

e898810


          Fix warnings from VS2022 and MinGW.

ea6312b


          Fixed mismatched-new-delete errors and run tests on Windows builds.

2674dd8


          Attempt to fix typo.

4dcd255


          Second attempt to fix typo.

7270be5


          Only run tests when options.tests is ON.

e405d08


          Set INSTALL_RPATH for test executables.

Npw they have to be signed, this has to be set so RUN_TESTS
can find libktx.


          Remake golden images for updated zstd encoder.

d68b601


          Use Ubuntu Jammy.

057b3ed


          Various fixes:

5f0d51a

* Fix Vulkan install on Linux to work for Jammy.
* Fix or turn off stringop-overflow warnings from GCC 11+.
* Remove warning disables for zstd.c as none are raised on latest version.


          Change one final focal to jammy.

df4cfd1


          Revert 'fix' in uastc_enc and disable stringop-overflow.

8083f04


          Disable stringops_overflow in uastc_enc for correct gcc version.

2e73183


          Fix mismatched-new-delete by adding custom delete.

f6f398c


          Fix version for warning disable on uastc_enc. Fix struct initialization.

dde0f15


          Fix some of the warnings from basisu code. Disable others.

7851c17


          Various fixes:

d1d60a9

* Warning disables for basisu_comp.cpp.
* Automatically find iUbuntu's VERSION_CODENAME for downloading
  Vulkan instead of hardcoding it.
* Fix documentation builds so they work after a clean and so
  clean doesn't balk on trying to clear non-empty directories.

MarkCallow added 17 commits

April 14, 2023 17:34


          Use brew to install Ninja. Update to newer upload-artifact.

8fefd0b


          Enable /W4 and /WX for CLangCL as well as MSVC.

b9d6c89


          Fix Ninja installs.

e52d5e6


          Fix ninja apt package name.

659757e


          Try upstream setup-mingw for set-output fix.

fa122d6


          Fix invocation of upstream setup-mingw.

9aeb744


          Fix environment variable dereferencing in YAML.

3c0e38e


          Initialize uninitialized variable.

5f7f033


          Try alternate initialization.

7767fc6


          Expand build matrix to include MSVC & CLangCL.

f4790d7


          Adjust #if for CLangCL.

cfed47c


          Fix matrix attributes for artifact & release uploads.

0743f0a


          Up Vulkan SDK version for Windows builds.

3d7f992


          Update for new Vulkan installer.

c208754


          Fix typo.

75992e4


          Update Vulkan SDK version.

f243a56


          Remove --verbose from VulkanSDK install.

a077a4c

MarkCallow merged commit 38f4858 into main

MarkCallow deleted the rm_vs2015 branch

April 15, 2023 11:14

MarkCallow pushed a commit that referenced this pull request


          Fix KTX2 header initialization in included BasisU code (#848)

5d203ce

A change we made to the the subrepo'ed BasisU code as part of the
mass warning fixes in PR #687 broke initialization of the KTX2 header
when BasisU is creating a .ktx2 file. This code is not used by libktx.
The fix is being committed to avoid inadvertently pushing the broken
code upstream.

The user who encountered this was doing something unsupported by libktx.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          CI and Build Improvements (KhronosGroup#687)

e63036c

    Remove VS2015 build from CI.
    Move Windows builds (except VS2017) to GitHub Actions.
    Run Windows builds and tests with both MSVC and CLangCL on VS2022.
    Build one configuration with VS2019 to ensure it still works.
    Build Windows release packages with VS2022 and CLangCL.
    Turn on warnings as errors. Fix bug that prevented /W4 for CLangCL. Fix all warnings.
    Update the included zstd.c and regen golden images for affected tests.
    Stop using deprecated code in GitHub Actions.
    Update Linux CI runner to Ubuntu Jammy
    Update Vulkan SDK used in Linux and Windows CI to 1.3.243.
    Fix issue with Doxygen builds that caused intermittent failures.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          Fix KTX2 header initialization in included BasisU code (KhronosGroup#848

99f332c

)

A change we made to the the subrepo'ed BasisU code as part of the
mass warning fixes in PR KhronosGroup#687 broke initialization of the KTX2 header
when BasisU is creating a .ktx2 file. This code is not used by libktx.
The fix is being committed to avoid inadvertently pushing the broken
code upstream.

The user who encountered this was doing something unsupported by libktx.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          CI and Build Improvements (KhronosGroup#687)

2cdbccc

    Remove VS2015 build from CI.
    Move Windows builds (except VS2017) to GitHub Actions.
    Run Windows builds and tests with both MSVC and CLangCL on VS2022.
    Build one configuration with VS2019 to ensure it still works.
    Build Windows release packages with VS2022 and CLangCL.
    Turn on warnings as errors. Fix bug that prevented /W4 for CLangCL. Fix all warnings.
    Update the included zstd.c and regen golden images for affected tests.
    Stop using deprecated code in GitHub Actions.
    Update Linux CI runner to Ubuntu Jammy
    Update Vulkan SDK used in Linux and Windows CI to 1.3.243.
    Fix issue with Doxygen builds that caused intermittent failures.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          Fix KTX2 header initialization in included BasisU code (KhronosGroup#848

e65f8e7

)

A change we made to the the subrepo'ed BasisU code as part of the
mass warning fixes in PR KhronosGroup#687 broke initialization of the KTX2 header
when BasisU is creating a .ktx2 file. This code is not used by libktx.
The fix is being committed to avoid inadvertently pushing the broken
code upstream.

The user who encountered this was doing something unsupported by libktx.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          CI and Build Improvements (KhronosGroup#687)

f9429ad

    Remove VS2015 build from CI.
    Move Windows builds (except VS2017) to GitHub Actions.
    Run Windows builds and tests with both MSVC and CLangCL on VS2022.
    Build one configuration with VS2019 to ensure it still works.
    Build Windows release packages with VS2022 and CLangCL.
    Turn on warnings as errors. Fix bug that prevented /W4 for CLangCL. Fix all warnings.
    Update the included zstd.c and regen golden images for affected tests.
    Stop using deprecated code in GitHub Actions.
    Update Linux CI runner to Ubuntu Jammy
    Update Vulkan SDK used in Linux and Windows CI to 1.3.243.
    Fix issue with Doxygen builds that caused intermittent failures.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          Fix KTX2 header initialization in included BasisU code (KhronosGroup#848

e1599b9

)

A change we made to the the subrepo'ed BasisU code as part of the
mass warning fixes in PR KhronosGroup#687 broke initialization of the KTX2 header
when BasisU is creating a .ktx2 file. This code is not used by libktx.
The fix is being committed to avoid inadvertently pushing the broken
code upstream.

The user who encountered this was doing something unsupported by libktx.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          CI and Build Improvements (KhronosGroup#687)

f9597f8

    Remove VS2015 build from CI.
    Move Windows builds (except VS2017) to GitHub Actions.
    Run Windows builds and tests with both MSVC and CLangCL on VS2022.
    Build one configuration with VS2019 to ensure it still works.
    Build Windows release packages with VS2022 and CLangCL.
    Turn on warnings as errors. Fix bug that prevented /W4 for CLangCL. Fix all warnings.
    Update the included zstd.c and regen golden images for affected tests.
    Stop using deprecated code in GitHub Actions.
    Update Linux CI runner to Ubuntu Jammy
    Update Vulkan SDK used in Linux and Windows CI to 1.3.243.
    Fix issue with Doxygen builds that caused intermittent failures.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          Fix KTX2 header initialization in included BasisU code (KhronosGroup#848

a963605

)

A change we made to the the subrepo'ed BasisU code as part of the
mass warning fixes in PR KhronosGroup#687 broke initialization of the KTX2 header
when BasisU is creating a .ktx2 file. This code is not used by libktx.
The fix is being committed to avoid inadvertently pushing the broken
code upstream.

The user who encountered this was doing something unsupported by libktx.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          CI and Build Improvements (KhronosGroup#687)

77a103a

    Remove VS2015 build from CI.
    Move Windows builds (except VS2017) to GitHub Actions.
    Run Windows builds and tests with both MSVC and CLangCL on VS2022.
    Build one configuration with VS2019 to ensure it still works.
    Build Windows release packages with VS2022 and CLangCL.
    Turn on warnings as errors. Fix bug that prevented /W4 for CLangCL. Fix all warnings.
    Update the included zstd.c and regen golden images for affected tests.
    Stop using deprecated code in GitHub Actions.
    Update Linux CI runner to Ubuntu Jammy
    Update Vulkan SDK used in Linux and Windows CI to 1.3.243.
    Fix issue with Doxygen builds that caused intermittent failures.

KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request


          Fix KTX2 header initialization in included BasisU code (KhronosGroup#848

c158235

)

A change we made to the the subrepo'ed BasisU code as part of the
mass warning fixes in PR KhronosGroup#687 broke initialization of the KTX2 header
when BasisU is creating a .ktx2 file. This code is not used by libktx.
The fix is being committed to avoid inadvertently pushing the broken
code upstream.

The user who encountered this was doing something unsupported by libktx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet