This repository was archived by the owner on Dec 5, 2018. It is now read-only.
Make ␣ available in Typewrite font, and fix ‘ and ’#2
Merged
k4b7 merged 1 commit intoKhan:masterfrom Jan 13, 2017
Merged
Conversation
gagern
added a commit
to edemaine/KaTeX
that referenced
this pull request
Jan 12, 2017
This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made.
gagern
added a commit
to edemaine/KaTeX
that referenced
this pull request
Jan 12, 2017
This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made.
k4b7
reviewed
Jan 12, 2017
| 0x15 => [0x306,-525,0], # \breve (combining) | ||
| 0x16 => [0x304,-525,0], # \bar (combining) | ||
| 0x17 => [0x30A,-525,0], # ring above (combining) | ||
| 0x20 => 0x2423, # graphic representation of space |
There was a problem hiding this comment.
Don't we want the actual space character it's self? \texttt{a b} in LaTeX puts a space between a and b instead of rendering a ␣.
Collaborator
Author
There was a problem hiding this comment.
But the glyph at position 0x20 is a ␣ not a space. I guess LaTeX doesn't actually use space characters, because spaces are usually strecthable nonetheless, so it will insert horizontal positioning instructions into the PostScript (and later PDF) and doesn't need a character for this.
There was a problem hiding this comment.
I see. I was hoping that cmtt would have an real space, but it sounds like that doesn't seem to be the case.
edemaine
pushed a commit
to edemaine/KaTeX
that referenced
this pull request
Jan 12, 2017
This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made.
|
LGTM. We can use |
k4b7
reviewed
Jan 13, 2017
| 0x27 => 2018, # left quote | ||
| 0x60 => 2019, # right quote | ||
| 0x27 => 0x2018, # left quote | ||
| 0x60 => 0x2019, # right quote |
There was a problem hiding this comment.
mapping.pl in the KaTeX repo will also have to be updated to match.
edemaine
pushed a commit
to edemaine/KaTeX
that referenced
this pull request
Aug 16, 2017
This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made.
k4b7
pushed a commit
to KaTeX/KaTeX
that referenced
this pull request
Sep 22, 2017
* Implement \verb * Implement @gagern's comments * \verb: look up characters one at a time. * Add screenshot test for \verb * Add error tests for \verb * Include space symbol in typewriter font, and fix single quotes This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made. * Add \verb* tests * \verb should use Typewriter-Regular font! * Switch \verb to use text mode and no-break space. * Screenshot update with Typewriter-Regular * \verb test: fix *, add commas to make spaces clear * Fix spaces and style handling * Implement @kevinbarabash's comments * Make error clearly an assertion failure * verb screenshot for Chrome
k4b7
pushed a commit
to KaTeX/katex-fonts
that referenced
this pull request
Feb 2, 2018
* Implement \verb * Implement @gagern's comments * \verb: look up characters one at a time. * Add screenshot test for \verb * Add error tests for \verb * Include space symbol in typewriter font, and fix single quotes This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made. * Add \verb* tests * \verb should use Typewriter-Regular font! * Switch \verb to use text mode and no-break space. * Screenshot update with Typewriter-Regular * \verb test: fix *, add commas to make spaces clear * Fix spaces and style handling * Implement @kevinbarabash's comments * Make error clearly an assertion failure * verb screenshot for Chrome
k4b7
pushed a commit
to KaTeX/katex-fonts
that referenced
this pull request
Feb 4, 2018
* Implement \verb * Implement @gagern's comments * \verb: look up characters one at a time. * Add screenshot test for \verb * Add error tests for \verb * Include space symbol in typewriter font, and fix single quotes This is based on Khan/MathJax-dev#2 which hasn't been accepted yet at the time this commit is made. * Add \verb* tests * \verb should use Typewriter-Regular font! * Switch \verb to use text mode and no-break space. * Screenshot update with Typewriter-Regular * \verb test: fix *, add commas to make spaces clear * Fix spaces and style handling * Implement @kevinbarabash's comments * Make error clearly an assertion failure * verb screenshot for Chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former is needed for KaTeX/KaTeX#614, while the latter is something I noticed in KaTeX/KaTeX#286 but only now understood the reason for, namely a hexadecimal number incorrectly marked as decimal.