Support \underline in text mode#1159
Merged
ry-randall merged 2 commits intoKaTeX:masterfrom Feb 14, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 59 59
Lines 3865 3865
Branches 648 648
=======================================
Hits 3068 3068
Misses 662 662
Partials 135 135
Continue to review full report at Codecov.
|
ry-randall
previously approved these changes
Feb 14, 2018
Member
ry-randall
left a comment
There was a problem hiding this comment.
Glad this was a simple/quick fix!
Member
|
@edemaine Meant to mention prior to approving. Perhaps we'd want to add a test for this? Might be able to add to the existing "Text" screenshot. |
Member
Author
|
I added a simple test to the LowerAccent one which currently tests |
ry-randall
approved these changes
Feb 14, 2018
Member
ry-randall
left a comment
There was a problem hiding this comment.
Thanks for the test. Glad this was a simple fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1158 with a one-line change. I could not find any other "long accents" that are supposed to work in text mode, but let me know if you find any!
Screenshot:
Comparison to LaTeX:
