Move connect/disconnect button into device list#96
Merged
Aurumaker72 merged 2 commits intomainfrom Nov 2, 2025
Merged
Conversation
also adds an unused refresh icon
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the device list functionality by removing the separate DeviceListControl user control and integrating its functionality directly into the MainForm. This simplifies the codebase architecture by eliminating an unnecessary abstraction layer.
Key changes:
- Removed standalone
DeviceListControlclass and merged device list logic intoMainForm - Added
arrow_refreshicon resource for the refresh button - Updated UI layout to integrate device list panel directly into the main form's split container
- Simplified label text from "Connected Devices" to "Devices"
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Key2Joy.Gui/MainForm_DeviceList.cs | Device list methods moved from DeviceListControl to MainForm as partial class methods |
| Key2Joy.Gui/MainForm.cs | Added device refresh call in constructor and refresh button click handler |
| Key2Joy.Gui/MainForm.Designer.cs | Integrated device list UI components directly into MainForm, replaced text-based refresh button with icon button |
| Key2Joy.Gui/MainForm.resx | Minor formatting change (newline at end of file) |
| Key2Joy.Gui/DeviceListControl.cs | Removed (merged into MainForm) |
| Key2Joy.Gui/DeviceListControl.Designer.cs | Removed (merged into MainForm) |
| Key2Joy.Gui/DeviceListControl.resx | Removed (merged into MainForm) |
| Key2Joy.Gui/Properties/Resources.resx | Added arrow_refresh icon resource, reorganized existing resources alphabetically |
| Key2Joy.Gui/Properties/Resources.Designer.cs | Added arrow_refresh property accessor |
| Key2Joy.Gui/Graphics/Icons/arrow_refresh.png | New refresh icon image file |
Files not reviewed (3)
- Key2Joy.Gui/DeviceListControl.Designer.cs: Language not supported
- Key2Joy.Gui/MainForm.Designer.cs: Language not supported
- Key2Joy.Gui/Properties/Resources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95