Adding more tests, fixing bugs in the process#48
Merged
Conversation
…o/fro scripting environment)
…o test + added docs
…away from singletons)
41f67c9 to
0652985
Compare
Closed
…into feature/add-tests
… order was accidentally correct earlier, this means we should really fix cleanup so we catch this sooner)
…own app) resolves #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I'm working on something I'm constantly manually going back and forth through the app to try see if I broke anything. This is unreliable and tedious.
I'm going to add more tests in order to resolve #34. I'll fix a bunch of bugs along the way, hopefully finding ways to write tests so those bugs don't slip under the radar again. This will likely require some refactoring in the process (since currently everything is quite tightly coupled).