Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new notification anchor service to the codebase, including the HTTP server implementation, a resolver-integrated client, shared request/response types, and tests to validate the basic flows.
Changes:
- Added
KeetaNetNotificationAnchorHTTPServerwith routes to register/list/delete targets and create/list/delete subscriptions. - Added a resolver-driven
KeetaNotificationAnchorClient/Providerfor calling notification providers discovered via service metadata. - Introduced shared notification types + typia-generated runtime assertions, plus Vitest coverage for server and client behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/notification/server.ts | New notification anchor HTTP server with signed request verification and service metadata exposure |
| src/services/notification/server.test.ts | Server tests for target/subscription lifecycle + invalid signature rejection |
| src/services/notification/common.ts | Shared API types, signable payload builders, and notification-specific error type |
| src/services/notification/common.generated.ts | typia-generated asserts/is helpers for notification API JSON |
| src/services/notification/client.ts | Resolver-integrated notification client/provider with signing + response validation |
| src/services/notification/client.test.ts | Client integration test wiring server metadata into Resolver and exercising flows |
| src/lib/resolver.ts | Adds notification service metadata + lookup criteria and filtering support |
| src/client/index.ts | Exposes Notification.Client and config types via the top-level client namespace |
rkeene
approved these changes
Mar 17, 2026
|
rkeene
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for notification anchors,
users can register subscriptions and targets, then receive notifications when those subscriptions trigger