Conversation
Srayman
approved these changes
Mar 10, 2026
Comment on lines
+89
to
+110
| } & ( | ||
| { | ||
| canPerformExchange: false; | ||
| } | ({ | ||
| canPerformExchange?: true; | ||
| } & ({ | ||
| /** | ||
| * Indicates that a quote is required before proceeding with the exchange | ||
| */ | ||
| requiresQuote: false; | ||
|
|
||
| /** | ||
| * Liquidity provider account if the user is not going to request a quote before the exchange | ||
| */ | ||
| account: KeetaNetAccount | KeetaNetStorageAccount; | ||
| } | { | ||
| /** | ||
| * Indicates that a quote is required before proceeding with the exchange, defaults to true | ||
| */ | ||
| requiresQuote?: true; | ||
| })) | ||
| ); |
Contributor
There was a problem hiding this comment.
Not necessary to fix now, but for future updates this might be easier to read as separate types of FX Server configs. The combination of union and intersect types starts to get harder to read.
Member
Author
There was a problem hiding this comment.
I think its okay to leave for now.
sephynox
reviewed
Mar 11, 2026
|
sephynox
approved these changes
Mar 11, 2026
rkeene
added a commit
that referenced
this pull request
Mar 16, 2026
This is KeetaNet Anchor v0.0.43 which has the following changes: - 339c9f3 Allow fx anchors to list the affinities they support in the metadata (#215) - 08972f9 Feature: Icons Storage Client (#214) - 6659d09 Add metadata and errors on which operations an asset movement provider supports for a rail (#171) - 6a7eba8 Upgrade to KeetaNet Node and Client v0.16.0 (#217) - 3957856 Add pricing only FX server and client methods to get pricing information from estimates (#210) - efa2c52 Add codegen to make adding new bank account locations easier (#168) - 6dd9abe Add additional opaque metadata to asset movement transfers (#213) - 1ad15ed Cleanup JSON Exports (#209)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.