Conversation
Keats
left a comment
There was a problem hiding this comment.
Looks good overall but I don't get why you added the GH actions file, Azure pipelines is already pretty fast.
.github/workflows/quick-check.yml
Outdated
| - name: Cargo check | ||
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: check |
There was a problem hiding this comment.
why add that compared to the current pipeline?
There was a problem hiding this comment.
I did not notice your pipeline at first :)
I also cannot run your pipeline in my fork (beside when opening a PR) so the github workflow makes it easier to check on my end.
I can remove it from the PR if you prefer.
There was a problem hiding this comment.
yes please, no need for 2 CI setup
Cargo.toml
Outdated
| description = "A simple way to get started with a project" | ||
| authors = ["Vincent Prouillet <hello@vincentprouillet.com>"] | ||
| license = "MIT" | ||
| description = "A simple way to get started with a project by scaffolding from a template powered by the tera engine" |
|
Any big features missing for your usage? |
Not at that point but I did not test extensively yet. I will happily report back or open a PR if so. Thanks for asking ! |
Since you asked :) #48 |
This PR fixes a few linter grumbles and mainly adds keywords for a better discovery.
I wish I found this project/repo earlier :)