Fix #647: declare dependency to result package explicitely and fix windows build#648
Merged
feret merged 4 commits intoKappa-Dev:masterfrom Jan 4, 2023
Merged
Conversation
Contributor
Author
|
(This PR should fix #647: I don't know why GitHub does not link this PR from the issue whereas the issue number is in the title) |
380168d to
69d724a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR declares the dependency to
resultpackage explicitly (the dependency was obtained transitively throughbinioubefore #645), and fixes windows build in GitHub action (the previous action depends on cygwin setup path to install thezipcommand, whereas this PR uses the provided7zcommand).