Fix #644: Use Buffer.t instead of Bi_outbuf.t#645
Merged
feret merged 1 commit intoKappa-Dev:masterfrom Oct 19, 2022
Merged
Conversation
90a9290 to
3ee48f6
Compare
This should make Kappa compatible with the latest version of yojson. Since ocaml-community/yojson#74, yojson does not rely on biniou buffers. The main drawback seems to be that `JsonUtil.write_to_channel` now writes everything to the memory (in a `Buffer.t`) before dumping the buffer to the channel.
3ee48f6 to
a8ec7a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make Kappa compatible with the latest version of yojson.
Since ocaml-community/yojson#74, yojson does not rely on biniou buffers.
The main drawback seems to be that
JsonUtil.write_to_channelnow writes everything to the memory (in aBuffer.t) before dumping the buffer to the channel.